From owner-cvs-ports@FreeBSD.ORG Sun Mar 20 17:31:54 2005 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF81B16A4CE; Sun, 20 Mar 2005 17:31:54 +0000 (GMT) Received: from connectmail.carleton.ca (connectmail.carleton.ca [134.117.2.12]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50E7B43D3F; Sun, 20 Mar 2005 17:31:54 +0000 (GMT) (envelope-from adamw@FreeBSD.org) Received: from [192.168.1.105] ([134.117.145.25]) by connectmail.carleton.ca (iPlanet Messaging Server 5.2 HotFix 2.02 (built Oct 21 2004)) with ESMTPSA id <0IDN009PYVD542@connectmail.carleton.ca>; Sun, 20 Mar 2005 12:31:53 -0500 (EST) Date: Sun, 20 Mar 2005 12:32:21 -0500 From: Adam Weinberger In-reply-to: <200503201704.j2KH4EAY028655@repoman.freebsd.org> To: Hye-Shik Chang Message-id: <423DB3A5.8070207@FreeBSD.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-Accept-Language: en-ca, en-gb, en-us, en User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-CA; rv:1.7.5) Gecko/20050105 Thunderbird/1.0 OMFG PANTS References: <200503201704.j2KH4EAY028655@repoman.freebsd.org> cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/liferea Makefile distinfo pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Mar 2005 17:31:54 -0000 Hye-Shik Chang wrote: > perky 2005-03-20 17:04:14 UTC > > FreeBSD ports repository > > Modified files: > net/liferea Makefile distinfo pkg-plist > Log: > Update to 0.9.1. Can this port please please be updated to respect WITH_MOZILLA? This port should work just fine if someone is using a firefox backend, but as it stands now, it forces people to have mozilla installed. Furthermore, you should not be using WITH_MOZILLA as a check variable without honouring its contents. Anybody who has mozilla-devel installed, or chooses to have firefox as their only mozilla-based backend, will have WITH_MOZILLA set in their environment. That means that there's no way to disable mozilla support for these people in liferea. Please look at galeon or epiphany or mplayer-plugin etc. to see what other ports do with the WITH_MOZILLA variable. I think you should do the following: .if WITH_MOZILLA=="firefox" || WITH_MOZILLA="mozilla" || \ WITH_MOZILLA="mozilla-devel" BUILD_DEPENDS= ${WITH_MOZILLA}:${PORTSDIR}/www/${WITH_MOZILLA} .else .if defined(WITH_MOZILLA) BUILD_DEPENDS= mozilla:${PORTSDIR}/www/mozilla .fi .fi RUN_DEPENDS= ${BUILD_DEPENDS} This way, if a user has WITH_MOZILLA set to the browser of their choice, that browser will be registered as a dependency (and liferea will stop corrupting everyone's package database every single time it's installed or upgraded). Users can still set WITH_MOZILLA to "yes" or whatever to force a dependency on mozilla, similar to what the port expects right now. # Adam -- Adam Weinberger adamw@magnesium.net || adamw@FreeBSD.org adamw@vectors.cx || adamw@gnome.org http://www.vectors.cx