From owner-svn-src-all@FreeBSD.ORG Sat Dec 24 21:36:19 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 3998B106564A; Sat, 24 Dec 2011 21:36:19 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 0A7BA14F542; Sat, 24 Dec 2011 21:36:19 +0000 (UTC) Message-ID: <4EF645D2.8080407@FreeBSD.org> Date: Sat, 24 Dec 2011 13:36:18 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Marius Strobl References: <201112241216.pBOCGd1H012696@svn.freebsd.org> In-Reply-To: <201112241216.pBOCGd1H012696@svn.freebsd.org> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228857 - in head/usr.bin: . csup X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 21:36:19 -0000 On 12/24/2011 04:16, Marius Strobl wrote: > On FreeBSD just use the MD5 implementation of libmd rather than that of > libcrypto so we don't need to relinquish csup when world is built without > OpenSSL. Did you benchmark this at all? I agree that keeping csup available absent openssl is a good goal, but csup is a prototypical "tool that does the same thing many thousands of times" so even tiny regressions could add up to a large cost in wall clock time. If the openssl version is faster, then conditionalizing where to get md5 is probably the right answer. If libmd is faster, then it's a net win. :) Doug -- [^L] Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/