Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 24 Dec 2011 13:36:18 -0800
From:      Doug Barton <dougb@FreeBSD.org>
To:        Marius Strobl <marius@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r228857 - in head/usr.bin: . csup
Message-ID:  <4EF645D2.8080407@FreeBSD.org>
In-Reply-To: <201112241216.pBOCGd1H012696@svn.freebsd.org>
References:  <201112241216.pBOCGd1H012696@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 12/24/2011 04:16, Marius Strobl wrote:
>   On FreeBSD just use the MD5 implementation of libmd rather than that of
>   libcrypto so we don't need to relinquish csup when world is built without
>   OpenSSL.

Did you benchmark this at all? I agree that keeping csup available
absent openssl is a good goal, but csup is a prototypical "tool that
does the same thing many thousands of times" so even tiny regressions
could add up to a large cost in wall clock time.

If the openssl version is faster, then conditionalizing where to get md5
is probably the right answer. If libmd is faster, then it's a net win. :)


Doug

-- 

		[^L]

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EF645D2.8080407>