From owner-freebsd-ppc@freebsd.org Sat Apr 25 14:01:20 2020 Return-Path: Delivered-To: freebsd-ppc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6E08C2B28A7 for ; Sat, 25 Apr 2020 14:01:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 498Xl42MbJz46Vv for ; Sat, 25 Apr 2020 14:01:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by freefall.freebsd.org (Postfix) id 26A111BD8E; Sat, 25 Apr 2020 14:01:20 +0000 (UTC) Delivered-To: powerpc@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id E3E6A1BC5A for ; Sat, 25 Apr 2020 14:01:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 498Xl34ycsz46Vp for ; Sat, 25 Apr 2020 14:01:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8B1CA8B9A for ; Sat, 25 Apr 2020 14:01:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 03PE1JAn000207 for ; Sat, 25 Apr 2020 14:01:19 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 03PE1JRJ000206 for powerpc@FreeBSD.org; Sat, 25 Apr 2020 14:01:19 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: powerpc@FreeBSD.org Subject: [Bug 245511] lang/gcc9: build with base GCC on powerpc64 elfv1 Date: Sat, 25 Apr 2020 14:01:19 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: buildisok X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: gerald@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gerald@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback- X-Bugzilla-Changed-Fields: resolution flagtypes.name bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Apr 2020 14:01:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245511 Gerald Pfeifer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Flags|maintainer-feedback?(gerald |maintainer-feedback- |@FreeBSD.org) | Status|Closed |Open --- Comment #3 from Gerald Pfeifer --- I was just looking into this today morning, but missed hitting "Save change= s" on my NACK. I approve backporting the change that was discussed and committed upstream.= =20=20 Your other changes appear somewhat random and lead to a crippled compiler/ runtime. Since this only affects powerpc* with the legacy ABI and you could remove the dependency on GCC 8 there, let's primarily focus on how you have been going about it. Given that lang/gcc9 is the default version of GCC in the ports tree I would definitely have avoided the PORTREVISION bump for the vast majority of users - and made this conditional in this special case. Changes to the lang/gcc ports should first go in via their lang/gcc-devel counter-parts. Alternatively, and I will do this in the next days (so do *not* forward port your patch) we can disable powerpc* for lang/gcc9-devel and focus on the lang/gcc9 port as clearly has been your approach over time. I recommend you run `portlint -C` going forward - it would have caught a formatting issue. I'll address that next time I touch this Makefile. And we don't do commit messages with lines of 299 chars. Is files/patch-Makefile.in truely necessary? If it is, how could overriding BOOT_CFLAGS ever have worked for anyone? According to gcc/gcc/doc/install.texi passing BOOT_CFLAGS via MAKE_ARGS should work. Can you please try that instead? (https://ftp.gnu.org/old-gnu/Manuals/make-3.79.1/html_chapter/make_9.html#S= EC90 explains why files/patch-Makefile.in should not be necessary.) --=20 You are receiving this mail because: You are on the CC list for the bug.=