From owner-cvs-all@FreeBSD.ORG Thu Oct 27 20:58:07 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA66B16A41F for ; Thu, 27 Oct 2005 20:58:07 +0000 (GMT) (envelope-from rik@cronyx.ru) Received: from hanoi.cronyx.ru (hanoi.cronyx.ru [144.206.181.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B3C543D46 for ; Thu, 27 Oct 2005 20:58:06 +0000 (GMT) (envelope-from rik@cronyx.ru) Received: (from root@localhost) by hanoi.cronyx.ru (8.13.0/vak/3.0) id j9RKkUYB011368 for cvs-all@freebsd.org.checked; Fri, 28 Oct 2005 00:46:30 +0400 (MSD) (envelope-from rik@cronyx.ru) Received: from cronyx.ru (localhost.cronyx.ru [127.0.0.1]) by hanoi.cronyx.ru (8.13.0/vak/3.0) with ESMTP id j9RKiqJo011329; Fri, 28 Oct 2005 00:44:53 +0400 (MSD) (envelope-from rik@cronyx.ru) Message-ID: <43613A16.70206@cronyx.ru> Date: Fri, 28 Oct 2005 00:35:34 +0400 From: Roman Kurakin User-Agent: Mozilla/5.0 (X11; U; Linux i686; ru-RU; rv:1.2.1) Gecko/20030426 X-Accept-Language: ru-ru, en MIME-Version: 1.0 To: obrien@freebsd.org References: <200509271657.j8RGvj2n015326@repoman.freebsd.org> <20051024072423.GA34909@dragon.NUXI.org> <200510241034.27073.jhb@freebsd.org> <20051025052018.GE55418@dragon.NUXI.org> <435E04AA.3080605@cronyx.ru> <20051026172734.GA99901@dragon.NUXI.org> <435FE099.6060508@cronyx.ru> <20051026224712.GA16118@dragon.NUXI.org> In-Reply-To: <20051026224712.GA16118@dragon.NUXI.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Roman Kurakin , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin Subject: Re: cvs commit: src/sys/dev/cp if_cp.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2005 20:58:07 -0000 Hi, David O'Brien: >On Thu, Oct 27, 2005 at 12:01:29AM +0400, Roman Kurakin wrote: > > >>David O'Brien: >> >> >>>On Tue, Oct 25, 2005 at 02:10:50PM +0400, Roman Kurakin wrote: >>> >>> >>>>The commit log didn't state what was the problem variable forward >>>>declaration or/and function >>>>forward declaration. >>>> >>>> >>>Since you became a committer 2003/12/18, I guess you haven't been part of >>>FreeBSD when we've worked on a GCC compiler upgrade. We make these type >>>of changes to make a new version of GCC build FreeBSD. The other choice >>>is to disconnect these drivers from the build. The commits done where >>>typical of what's been done for the past decade. >>> >>> >>> >>Please provide detailed technical information what is wrong in my >>change of your commit. >> >> > >Instead of arguing this with you as it is probably fruitless. >If you're going to pull the "maintainer" card, then please have these >drivers moved to src/sys/contrib and note them in src/MAINTAINERS. That >way this isn't a landmine for other committers to step on. > I do not want to buffer development proccess since I cant guarantee quick response at any random time. From my point of view for most of commits there is enough post-commit review. Since all (most) changes go through current I have enough time to fix them in case of wrong (from my point of view) change. >>I do not want to list them in src/MAINTAINERS cause I think it is >>better to allow any commits. >>Cases such this one is rare. >> >> > >Rare or not, they can occur so why not take easy steps to avoid strife? > If you insist I could add myself to MAINTAINERS with post-commit review just to inform that I am exist. But I doubt that this will close all rare cases. rik