From owner-p4-projects@FreeBSD.ORG  Mon May 18 14:38:53 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 33B551065677; Mon, 18 May 2009 14:38:53 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CDE141065672;
	Mon, 18 May 2009 14:38:52 +0000 (UTC)
	(envelope-from upczhsh@gmail.com)
Received: from mail-qy0-f105.google.com (mail-qy0-f105.google.com
	[209.85.221.105])
	by mx1.freebsd.org (Postfix) with ESMTP id 6D5B58FC14;
	Mon, 18 May 2009 14:38:52 +0000 (UTC)
	(envelope-from upczhsh@gmail.com)
Received: by qyk3 with SMTP id 3so5746582qyk.3
	for <multiple recipients>; Mon, 18 May 2009 07:38:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:sender:received:in-reply-to
	:references:date:x-google-sender-auth:message-id:subject:from:to:cc
	:content-type; bh=NLrlR+PkMIhjlyz4GOLCQsMPJd6BsxqBTIm8SFH19Lc=;
	b=aOtyyLqHZsoFu2PL+8YJuAp6UnmaoaxWkfX65y38RfPfhxlUZedRwY6tQCBaGQ7nmy
	WWK6lIEkSCE/etQv/F0IOwvE9Or0757hMVZLpH9h5LUUp59FtBbC1gogOVJXt5vpqFJl
	8hPMVwbuKBbAOdgLea1SXYZj700yU6sBXQmmE=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	b=lcPxAuTpqkMmYVE0TV7pJdvYH7vfm00K+csAqFXIlXUZTyCXX59Oi9Xun4vrx2TkXD
	NZG+wOR7kNzydfCNYAl/8AIlFfEucXxMAUKa1NjmRe2vyrAgCG4PGZ4oTD+t3yeYqQx0
	9ncQrQ15ZKZZ7DlTak4cmFUNFmfQ7w9M2Z20w=
MIME-Version: 1.0
Sender: upczhsh@gmail.com
Received: by 10.229.85.4 with SMTP id m4mr3012277qcl.55.1242655621304; Mon, 18 
	May 2009 07:07:01 -0700 (PDT)
In-Reply-To: <3bbf2fe10905170632g7ad74f3dk3cdb3ad5576da394@mail.gmail.com>
References: <200905171226.n4HCQXS9011874@repoman.freebsd.org>
	<3bbf2fe10905170632g7ad74f3dk3cdb3ad5576da394@mail.gmail.com>
Date: Mon, 18 May 2009 22:07:01 +0800
X-Google-Sender-Auth: e1088a59b5b8d775
Message-ID: <8126ef5c0905180707w7c238133q37e3d42ea321ead2@mail.gmail.com>
From: Zhao Shuai <zhaoshuai@freebsd.org>
To: Attilio Rao <attilio@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: Perforce Change Reviews <perforce@freebsd.org>,
	John Baldwin <jhb@freebsd.org>
Subject: Re: PERFORCE change 162206 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 May 2009 14:38:54 -0000

Yes, that is an elegant solution and I will do that.
What's your opinion, John?

This week I just wanna make fifo work using the existing
pipe code, so current modification in pipe code looks ugly.
But I think it helps me to figure out which part of pipe code
can be shared.

2009/5/17 Attilio Rao <attilio@freebsd.org>

>
> I'm not sure how do you and John want to organize the work, but when I
> was thinking about it my main idea was firstly to refactorize the pipe
> code, identifying common parts that can be shared and put under
> subr_something.c (for example) to be sucked in by both pipes and FIFOs
> main code.
>
>
-- 
Regards,
Zhao