From owner-freebsd-ruby@FreeBSD.ORG Mon Dec 21 22:22:26 2009 Return-Path: Delivered-To: freebsd-ruby@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 90F10106568F for ; Mon, 21 Dec 2009 22:22:26 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from mx0.deglitch.com (backbone.deglitch.com [IPv6:2001:16d8:fffb:4::abba]) by mx1.freebsd.org (Postfix) with ESMTP id 3C5768FC18 for ; Mon, 21 Dec 2009 22:22:26 +0000 (UTC) Received: from orion.SpringDaemons.com (adsl-99-48-191-9.dsl.snfc21.sbcglobal.net [99.48.191.9]) by mx0.deglitch.com (Postfix) with ESMTPA id 0D1FF8FC4E; Tue, 22 Dec 2009 01:22:25 +0300 (MSK) Received: from orion (localhost [127.0.0.1]) by orion.SpringDaemons.com (Postfix) with SMTP id 1729D39C24; Mon, 21 Dec 2009 14:22:19 -0800 (PST) Date: Mon, 21 Dec 2009 14:22:19 -0800 From: Stanislav Sedov To: "KISHIMOTO, Makoto" Message-Id: <20091221142219.0e51b1a8.stas@FreeBSD.org> In-Reply-To: <20091220121244.f0eaf37c.ksmakoto@dd.iij4u.or.jp> References: <20091220121244.f0eaf37c.ksmakoto@dd.iij4u.or.jp> Organization: The FreeBSD Project X-Mailer: carrier-pigeon Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: freebsd-ruby@freebsd.org Subject: Re: [PATCH] portupgrade, get_all_depends method crashes X-BeenThere: freebsd-ruby@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Ruby discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2009 22:22:26 -0000 On Sun, 20 Dec 2009 12:12:44 +0900 "KISHIMOTO, Makoto" mentioned: > Hello, > > In portupgrade, get_all_depends method crashes if portdir not found. > (for example http://www.freebsd.org/cgi/query-pr.cgi?pr=140192 ) > > following patch is workaround. > > --- portupgrade.ORG 2009-12-20 10:11:00.000000000 +0900 > +++ portupgrade 2009-12-20 10:16:10.000000000 +0900 > @@ -834,7 +834,7 @@ > depends = Set.new > > portdir = $portsdb.portdir(origin) > - return nil if not File.directory?(portdir) > + return [] if not File.directory?(portdir) > > begin > run_make_config(portdir, origin) if $config Thank you, I committed your fix to projects CVS. -- Stanislav Sedov ST4096-RIPE