From nobody Sun Jan 29 00:54:47 2023 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P4CWt0Q86z3blxM for ; Sun, 29 Jan 2023 00:54:50 +0000 (UTC) (envelope-from yuri@aetern.org) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4P4CWs4Rvqz3pmH for ; Sun, 29 Jan 2023 00:54:49 +0000 (UTC) (envelope-from yuri@aetern.org) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=aetern.org header.s=fm3 header.b=DWHJ6McK; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=McdMIlk5; spf=pass (mx1.freebsd.org: domain of yuri@aetern.org designates 66.111.4.28 as permitted sender) smtp.mailfrom=yuri@aetern.org; dmarc=none Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5CD9E5C0194 for ; Sat, 28 Jan 2023 19:54:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 28 Jan 2023 19:54:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aetern.org; h=cc :content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm3; t=1674953689; x=1675040089; bh=H3r2lU2nOD xfWLLkVRM+ROHliXdAYH+3RiC39XDn6EI=; b=DWHJ6McKtg/MDQg/+7yB3hXTiQ 8viVCuuUqCM3KUFkVEZimpynAFvA2979zfUS9wbH21X7jQR9YAG8oFbrdq2PROeC 106tUmROvLmV3jGd3/guTM3Px5OZ5mwszTFp1NAr0ddcAS1afeUcw4mjB/Hoo9Lg 7+lCglIf0IXbd3f3Nuaeg6jpGH3Gr2IbS7PC3G4lgifqXygLhMA6V2qC2Q7vzcNC RUodOXCcecf8o222skE7twk2sbqGC4WwmtrADGgOG7N0kWZWxm+mdKAY0SXqpBru ZKS0s1eE7utJNxbtHUF2LIFTR6HqB/dADptiGN0lOvz6rGAF0/oHz43LMDqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674953689; x=1675040089; bh=H3r2lU2nODxfWLLkVRM+ROHliXdA YH+3RiC39XDn6EI=; b=McdMIlk5zPK18+1/nCUNot/wtp2Tj6hymnuHQAaCmbsc kDenQiLI31NgVLYUv8E1YL+HaSvVBK1L56n/sjYN8B3N9eRZsMma4Bpl/9EejnZq UIKpgi0ajiC8fzlMBrxACx8ex5styy9nH9Cr914MBQ1nVAhEINulV/72hKIfjuoq djU/kOeYMjPP6AAMcsVph0DfKOACbCgAIiAhwEh8mNgP1djsB64TOEPsClqUd5Xh SRkOpo6xxqp0MRyRSecHJzQxnI2/KdIwQ13m5F2ButPvyCSldsU+px4e7S4fi0tm tUZjKHo3MBSuuliT+sGb2WPAopTCcPV9ytjtPLjURg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvledgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfvhffutgfgsehtkeertd dtfeejnecuhfhrohhmpegjuhhrihcuoeihuhhrihesrggvthgvrhhnrdhorhhgqeenucgg tffrrghtthgvrhhnpedufeevkeffgfduueeikeelvefhjefgfeetteffffejveetjeekfe efvdfftedtueenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpeihuhhrihesrggvthgvrhhnrdhorhhg X-ME-Proxy: Feedback-ID: i0d79475b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sat, 28 Jan 2023 19:54:48 -0500 (EST) Message-ID: <70f53d17-46eb-c299-1a93-bf28858c1685@aetern.org> Date: Sun, 29 Jan 2023 01:54:47 +0100 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: current@freebsd.org From: Yuri Subject: vt and keyboard accents Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4P4CWs4Rvqz3pmH X-Spamd-Bar: - X-Spamd-Result: default: False [-1.60 / 15.00]; DWL_DNSWL_LOW(-1.00)[messagingengine.com:dkim]; R_DKIM_ALLOW(-0.20)[aetern.org:s=fm3,messagingengine.com:s=fm3]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.28:c]; RWL_MAILSPIKE_GOOD(-0.10)[66.111.4.28:from]; RCVD_IN_DNSWL_LOW(-0.10)[66.111.4.28:from]; ASN(0.00)[asn:19151, ipnet:66.111.4.0/24, country:US]; PREVIOUSLY_DELIVERED(0.00)[current@freebsd.org]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[aetern.org:+,messagingengine.com:+]; local_wl_from(0.00)[yuri@aetern.org]; DMARC_NA(0.00)[aetern.org] X-Rspamd-Pre-Result: action=no action; module=multimap; Matched map: local_wl_from X-ThisMailContainsUnwantedMimeParts: N Looking into an issue with accents input for vt and cz (so /usr/share/vt/keymaps/cz.kbd) keyboard where some of the accents are working and other result weird unrelated characters output. Checking kbdcontrol -d output, there is an obvious difference with keymap contents -- all mappings are trimmed down to 1 byte after reading: kbdcontrol: dacu 180 ( 180 180 ) ( 'S' 'Z' ) ( 'Z' 'y' ) ( 's' '[' ) ( 'z' 'z' ) ( 'R' 'T' ) ( 'A' 193 ) ( 'L' '9' ) ( 'C' 006 ) ( 'E' 201 ) ( 'I' 205 ) ( 'N' 'C' ) ( 'O' 211 ) ( 'U' 218 ) ( 'Y' 221 ) ( 'r' 'U' ) ( 'a' 225 ) ( 'l' ':' ) ( 'c' 007 ) ( 'e' 233 ) ( 'i' 237 ) ( 'n' 'D' ) ( 'o' 243 ) ( 'u' 250 ) ( 'y' 253 ) keymap: dacu 0xb4 ( 0xb4 0xb4 ) ( 'S' 0x015a ) ( 'Z' 0x0179 ) ( 's' 0x015b ) ( 'z' 0x017a ) ( 'R' 0x0154 ) ( 'A' 0xc1 ) ( 'L' 0x0139 ) ( 'C' 0x0106 ) ( 'E' 0xc9 ) ( 'I' 0xcd ) ( 'N' 0x0143 ) ( 'O' 0xd3 ) ( 'U' 0xda ) ( 'Y' 0xdd ) ( 'r' 0x0155 ) ( 'a' 0xe1 ) ( 'l' 0x013a ) ( 'c' 0x0107 ) ( 'e' 0xe9 ) ( 'i' 0xed ) ( 'n' 0x0144 ) ( 'o' 0xf3 ) ( 'u' 0xfa ) ( 'y' 0xfd ) Source of the problem is the following definition in sys/sys/kbio.h: struct acc_t { u_char accchar; u_char map[NUM_ACCENTCHARS][2]; }; While the keymaps were converted to have the unicode characters for vt in the commit below, the array to store them (map) was missed, or was there a reason for this? --- commit 7ba08f814546ece02e0193edc12cf6eb4d5cb8d4 Author: Stefan Eßer Date: Sun Aug 17 19:54:21 2014 +0000 Attempt at converting the SYSCONS keymaps to Unicode for use with NEWCONS. I have spent many hours comparing source and destination formats, and hope to have caught the most severe conversion errors. --- I have tried the following patch and it allows me to enter all accents documented in the keymap, though I must admit I'm not sure it does not have hidden issues: diff --git a/sys/sys/kbio.h b/sys/sys/kbio.h index 7f17bda76c5..fffeb63e226 100644 --- a/sys/sys/kbio.h +++ b/sys/sys/kbio.h @@ -200,7 +200,7 @@ typedef struct okeymap okeymap_t; struct acc_t { u_char accchar; - u_char map[NUM_ACCENTCHARS][2]; + int map[NUM_ACCENTCHARS][2]; };