Date: Fri, 15 Nov 2002 15:14:30 -0500 (EST) From: Andrew Gallatin <gallatin@cs.duke.edu> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: Sam Leffler <sam@FreeBSD.org>, "luigi@freebsd.org.cvs-committers"@FreeBSD.org, cvs-all@FreeBSD.org Subject: if_xname ( was Re: cvs commit: src/sys/dev/an if_an.c if_an_isa.c if_an_pccard.c if_an_pci.c src/sys/dev/ar if_ar.c src/sys/dev/awi awi.c if_awi_pccard.c src/sys/dev/bge if_bge.c if_bgereg.h src/sys/dev/cm smc90cx6.c src/sys/dev/cnw if_cnw.c src/sys/dev/cs ...) Message-ID: <15829.21926.961058.610694@grasshopper.cs.duke.edu> In-Reply-To: <20021115120447.C4826@Odin.AC.HMC.Edu> References: <200211142354.gAENstXE004776@repoman.freebsd.org> <20021115143004.A54902@grasshopper.cs.duke.edu> <20021115114335.A4826@Odin.AC.HMC.Edu> <15829.20547.24539.647339@grasshopper.cs.duke.edu> <20021115120447.C4826@Odin.AC.HMC.Edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Brooks Davis writes: > On Fri, Nov 15, 2002 at 02:51:31PM -0500, Andrew Gallatin wrote: > > > > Brooks Davis writes: > > > > > > I've got the if_xname change coming, but we're waiting until after DP2 > > > because it breaks some ports. I'm going to try and roll up a new patch > > > soon and see if Kris can to do a ports run soon. > > > > Can you remind me what the motivation for the changes are? I started > > reading about it somewhere in the middle of a thread, so I'm curious > > why you want to make these changes. > > The short list is, increased compatability with NetBSD and OpenBSD, > ability to name interfaces arbitrarily (e.g. lax-t1, sfo-ds1, etc.) and > thus usefully rename interfaces, cleaner code for most uses of either > if_name or if_unit, and hopefully, easier implementation of intresting > cloning functions like fxp0.10 as a vlan interface. > > The downside is an API incompatability, but we're talking about trading > two assignments for an snprintf in most drivers so the #if's aren't too > bad. Yeah, I looked at the patch, got all excited, then realized its just one more tiny macro in my if_start() routine that I share with FreeBSD, MacOS-X and Tru64, so I agree its no big deal for drivers. But what about ip_if*'s (ab)use of if_unit in the critical path? Introducing extra code here to do string parsing is my only concern. If Luigi is OK with it, then I am too. Drew To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15829.21926.961058.610694>