From owner-freebsd-ports-bugs@FreeBSD.ORG Tue May 14 21:20:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 78994EF2 for ; Tue, 14 May 2013 21:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 6AEBDDFB for ; Tue, 14 May 2013 21:20:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r4ELK1Yw041584 for ; Tue, 14 May 2013 21:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r4ELK1H1041583; Tue, 14 May 2013 21:20:01 GMT (envelope-from gnats) Date: Tue, 14 May 2013 21:20:01 GMT Message-Id: <201305142120.r4ELK1H1041583@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Cc: From: Kevin Zheng Subject: Re: ports/177857: [patch] Update x11/slim to 1.3.5 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Kevin Zheng List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 May 2013 21:20:01 -0000 The following reply was made to PR ports/177857; it has been noted by GNATS. From: Kevin Zheng To: Raphael Kubo da Costa Cc: bug-followup@FreeBSD.org Subject: Re: ports/177857: [patch] Update x11/slim to 1.3.5 Date: Tue, 14 May 2013 16:13:32 -0500 On 05/14/2013 15:55, Raphael Kubo da Costa wrote: >> LICENSE= GPLv2 >> +LICENSE_FILE= ${WRKSRC}/COPYING > > This shouldn't be needed. Standard licenses such as GPLv2 already have a > copy in Templates/Licenses. Ahh, thanks. I didn't realize that bsd.licenses.mk automatically sets the LICENSE_FILE for standard license. >> USES= cmake pkgconfig >> +USE_RC_SUBR= slim >> USE_XORG= ice sm x11 xau xdmcp xext xft xmu xorg-server xrender xt >> -USE_RC_SUBR= slim >> SUB_FILES= pkg-message > > Is there a reason for this change other than ordering the "USE_" > variables alphabetically? Otherwise it just makes svn blaming more > difficult. No, I just felt the urge to have everything sorted. Feel free to undo this change, everything works out either way. >> . if ${PORT_OPTIONS:MPAM} >> + @${MKDIR} ${PREFIX}/etc/pam.d > > You shouldn't need to do this, ${PREFIX}/etc/pam.d is part of the > standard directories defined in Templates/BSD.local.dist. Thanks, I wasn't sure. Now I know where to look in the future! Thanks, Kevin Zheng