From owner-freebsd-bugs Fri Jan 24 13:30:04 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id NAA20828 for bugs-outgoing; Fri, 24 Jan 1997 13:30:04 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id NAA20822; Fri, 24 Jan 1997 13:30:02 -0800 (PST) Date: Fri, 24 Jan 1997 13:30:02 -0800 (PST) Message-Id: <199701242130.NAA20822@freefall.freebsd.org> To: freebsd-bugs Cc: From: se@freebsd.org (Stefan Esser) Subject: Re: kern/2463: pci gets included without being asked for Reply-To: se@freebsd.org (Stefan Esser) Sender: owner-bugs@freebsd.org X-Loop: FreeBSD.org Precedence: bulk The following reply was made to PR kern/2463; it has been noted by GNATS. From: se@freebsd.org (Stefan Esser) To: andrew@ugh.net.au Cc: freebsd-gnats-submit@freebsd.org Subject: Re: kern/2463: pci gets included without being asked for Date: Fri, 24 Jan 1997 22:25:11 +0100 On Jan 12, andrew@ugh.net.au wrote: > >Synopsis: pci gets included without being asked for > >Description: > Despite not having pci mentioned in my kernel config file at all the > makefile produced by config still contains $S/pci/wd82371.c. Is this a > bug? The file seems to be something about pci ide controllers but I'm not > sure...I definitley dont have pci :-( Well, and then you definitely don't care, whether wd82371.c will be compiled, since it is pre-processed into an empty file, if you don't have pci0 configured ... (I.e. the whole body of wd82371.c is included in "#if NPCI > 0".) It is debatable, whether wd82371.c should be included into the Makefile, if "wd0" is defined, or whether it should depend on pci0, but would then contain an "#if NWD > 0" ... (And I would in fact prefer the latter method.) This is not a real problem: The /sys/conf/files format just does not allow to include a file only if there are TWO devices configured in the kernel configuration file. This is dealt with by checking for the second condition from within the source file. I will therefor close the PR.