Date: Thu, 13 May 2010 17:24:48 -0400 From: Boris Kochergin <spawk@acm.poly.edu> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: freebsd-fs@freebsd.org, John Baldwin <jhb@FreeBSD.org> Subject: Re: ZFS and __FreeBSD_version Message-ID: <4BEC6E20.2080005@acm.poly.edu> In-Reply-To: <20100513211750.GA2015@garage.freebsd.pl> References: <4BEB40EB.2030206@acm.poly.edu> <4BEBE634.4080102@FreeBSD.org> <20100513211750.GA2015@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
Pawel Jakub Dawidek wrote: > On Thu, May 13, 2010 at 07:44:52AM -0400, John Baldwin wrote: > >> Boris Kochergin wrote: >> >>> Hi. Can __FreeBSD_version be bumped if ZFS's userland API is ever >>> changed again? I got slightly bitten by the >>> state_to_name()-to-zpool_state_to_name() change from version 6 to >>> version 13 and would like a reliable way of keeping track of this type >>> of stuff in the future. Thanks. >>> >> Yes, it should be bumped anytime the API changes. That is definitely a >> bug that it wasn't done properly last time. >> > > I must disagree here. libzfs API is for ZFS internal use only and is > subject to change at any time. This is true for OpenSolaris as well. > We, of course, can bump __FreeBSD_version if it helps, but one shouldn't > expect libzfs API being stable or there is any care taken to maintain > backward compatibility Sure, I understand that it's unstable, but a different __FreeBSD_version for each time it changes (which isn't that often in FreeBSD) would allow my code to do the right thing to cope with it, at the preprocessor. -Boris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BEC6E20.2080005>