From owner-freebsd-stable@FreeBSD.ORG Wed Jun 4 18:12:37 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 73DE71065674; Wed, 4 Jun 2008 18:12:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id ECACE8FC12; Wed, 4 Jun 2008 18:12:36 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m54ICTuK087314; Wed, 4 Jun 2008 14:12:30 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-stable@freebsd.org Date: Wed, 4 Jun 2008 10:30:37 -0400 User-Agent: KMail/1.9.7 References: <484602C5.7000400@FreeBSD.org> In-Reply-To: <484602C5.7000400@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806041030.37413.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Wed, 04 Jun 2008 14:12:30 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/7363/Wed Jun 4 12:58:30 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.1 required=4.2 tests=BAYES_00, DATE_IN_PAST_03_06, NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: "Carlos A. M. dos Santos" , Jeremy Chadwick , Doug Barton Subject: Re: Why does sysinstall still limits cylinders to 65535? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jun 2008 18:12:37 -0000 On Tuesday 03 June 2008 10:49:41 pm Doug Barton wrote: > Carlos A. M. dos Santos wrote: > > On Mon, May 26, 2008 at 3:24 AM, Jeremy Chadwick wrote: > >> On Sun, May 25, 2008 at 11:52:06PM -0300, Carlos A. M. dos Santos wrote: > >>> I have been struglling with sysinstall, attempting to make it handle > >>> the geometry of some large SATA drives. After a lot of effort I > >>> decided to stop suffering and modified the program in order to > >>> circumvent the outdated limit of 65535 cylinders (see attached patch). > >>> I'm thinking about submitting a PR with a change request but I'd like > >>> to get some additional opinions first. I did not test it in "batch" > >>> mode, so it would be great if any kind soul did this. > >> Carlos, bottom line is to simply ignore the geometry warning you see. > >> > >> For others... > >> > >> This is just added evidence that the humongous warning spit out during > >> sysinstall's fdisk is confusing users (many taking it very seriously > >> when there's really no problem at all). > >> > >> I think this is the third time someone's brought this up in the past > >> couple months... > > > > Sorry if I sound annoying but nobody else answered. I still believe > > that something must be done to fix sysinstall, so I'm asking you > > (where "you" means the "others" in Jeremy's message) to provide some > > additional feedback. Please fill-in the dots in one or more of the > > following options: > > > > 1. We can not make such change sysinstall because ... > > > > 2. Your patch is not correct/sufficient. I would be better if ... > > > > 3. Please submit a PR. It will momentarily be reviewed by ... > > > > 4. Give up. Nobody here cares about this issue. > > 5. -stable is not the right list to discuss sysinstall issues. > freebsd-hackers would be the first choice, if you don't get a response > there, -current would be the next. > > Send the PR first, and in your message give a brief background of your > issue and a URL for the PR. That way when it gets reviewed the feedback > will be consolidated into one convenient location. > > If you want "momentary" review for your work, open source is probably > not the arena you should be looking to contribute in. 6. The Real Fix(tm) would be to change sysinstall to allow use of GPT partitions (GPT doesn't use C/H/S at all, so the warning would only be present for the MBR/BSD label case) and then enable those by default. You would still need to allow for MBR/BSD layouts for some embedded devices that don't support the BIOS EDD packet mode (i.e. doing disk I/O using LBA's rather than C/H/S). -- John Baldwin