Date: Wed, 9 Nov 2005 15:57:12 +0200 From: Vasil Dimov <vd@datamax.bg> To: FreeBSD-gnats-submit@FreeBSD.org Cc: me@cs.hmc.edu, roessler@does-not-exist.org, obrien@FreeBSD.org Subject: ports/88729: [patch] textproc/urlview segfaults on amd64 Message-ID: <20051109135712.GA44313@qlovarnika.bg.datamax> Resent-Message-ID: <200511091400.jA9E0RJj054973@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 88729 >Category: ports >Synopsis: [patch] textproc/urlview segfaults on amd64 >Confidential: no >Severity: serious >Priority: high >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Nov 09 14:00:26 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Vasil Dimov >Release: FreeBSD 6.0-STABLE amd64 >Organization: DataMax >Environment: System: FreeBSD qlovarnika.bg.datamax 6.0-STABLE FreeBSD 6.0-STABLE #0: Tue Nov 8 09:24:59 EET 2005 root@qlovarnika.bg.datamax:/usr/obj/usr/src/sys/QLOVARNIKA amd64 >Description: textproc/urlview uses its internal function char *quote() without it being declared so its return type defaults to int, which results in a segmentation fault on machines where sizeof(int) != sizeof(char *) >How-To-Repeat: $ uname -m amd64 $ cd /usr/ports/textproc/urlview $ make install clean $ echo 'http://www.a.b' |urlview <enter> <enter> Segmentation fault: 11 (core dumped) $ >Fix: --- urlview_quote.diff begins here --- diff -urN --exclude=CVS --exclude=work --exclude=README.html urlview.orig/Makefile urlview/Makefile --- urlview.orig/Makefile Wed Oct 15 19:59:12 2003 +++ urlview/Makefile Wed Nov 9 15:39:13 2005 @@ -8,7 +8,7 @@ PORTNAME= urlview PORTVERSION= 0.9 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= textproc www MASTER_SITES= ftp://ftp.mutt.org/mutt/contrib/ \ ftp://ftp.sunsite.auc.dk/pub/mail/mutt/contrib/ \ diff -urN --exclude=CVS --exclude=work --exclude=README.html urlview.orig/files/patch-urlview.c urlview/files/patch-urlview.c --- urlview.orig/files/patch-urlview.c Thu Jan 1 02:00:00 1970 +++ urlview/files/patch-urlview.c Wed Nov 9 15:35:53 2005 @@ -0,0 +1,11 @@ +--- urlview.c.orig Wed Nov 9 15:34:39 2005 ++++ urlview.c Wed Nov 9 15:35:06 2005 +@@ -46,6 +46,8 @@ + #include <rx/rxposix.h> + #endif + ++#include "quote.h" ++ + #define DEFAULT_REGEXP "(((https?|ftp|gopher)://|(mailto|file|news):)[^' \t<>\"]+|(www|web|w3)\\.[-a-z0-9.]+)[^' \t.,;<>\"\\):]" + #define DEFAULT_COMMAND "url_handler.sh %s" + #define SYSTEM_INITFILE "/usr/local/etc/urlview.conf" --- urlview_quote.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051109135712.GA44313>