From owner-freebsd-net@FreeBSD.ORG Tue Jul 2 03:39:37 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 1FAB5FD1; Tue, 2 Jul 2013 03:39:37 +0000 (UTC) (envelope-from brian@freebsd.org) Received: from smtp-out-01.shaw.ca (smtp-out-01.shaw.ca [64.59.136.137]) by mx1.freebsd.org (Postfix) with ESMTP id D7BED1247; Tue, 2 Jul 2013 03:39:36 +0000 (UTC) X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=SNukfclIDc7GjKe+LHtSoPUBJt/gHPuqMk7EpfoOdzs= c=1 sm=1 a=5nrBDZ_FnQAA:10 a=dBRESv0yCI8A:10 a=BLceEmwcHowA:10 a=kj9zAlcOel0A:10 a=Jvqgub9IZPV2TmRqH1mFPg==:17 a=6I5d2MoRAAAA:8 a=MMwg4So0AAAA:8 a=lJWLfxBmVappjzjelGEA:9 a=CjuIK1q_8ugA:10 a=SV7veod9ZcQA:10 a=WJ3hkfHDukgA:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 Received: from unknown (HELO gw.Awfulhak.org) ([174.7.169.46]) by smtp-out-01.shaw.ca with ESMTP; 01 Jul 2013 21:39:30 -0600 Received: from [67.215.89.21] ([67.215.89.21]) (authenticated bits=0) by gw.Awfulhak.org (8.14.7/8.14.7) with ESMTP id r623dRtP061804 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 1 Jul 2013 20:39:28 -0700 (PDT) (envelope-from brian@freebsd.org) Subject: Re: Removing support for FreeBSD 2.x in PPP Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Content-Type: text/plain; charset=us-ascii From: Brian Somers In-Reply-To: Date: Mon, 1 Jul 2013 20:39:33 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <0BC5BCAE-8B7E-4F38-985A-C2E58A01DB9A@freebsd.org> References: To: Robert Millan X-Mailer: Apple Mail (2.1508) X-Spam-Status: No, score=2.2 required=5.0 tests=RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gw.lan.Awfulhak.org Cc: freebsd-net@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jul 2013 03:39:37 -0000 There are certainly no objections from me. On Jul 1, 2013, at 3:35 PM, Robert Millan wrote: > Hi, >=20 > Is there any concern if the arcane FreeBSD 2.x build logic is removed = from PPP? >=20 > These ifdefs are currently being hit when building on GNU/kFreeBSD > (because of __FreeBSD__ value being undefined, i.e. 0). >=20 > I guess one could add even more ifdef logic could be added to handle > that, but it seems a bit pointless since 2.x is such an old release > series. >=20 > If there is no objection I will check in the attached patch. >=20 > -- > Robert Millan > -- Brian Somers = Don't _EVER_ lose your sense of humour ! =