From nobody Wed Oct 11 19:06:26 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S5Mgl04hcz4wYrk; Wed, 11 Oct 2023 19:06:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S5Mgk6hDbz4b1M; Wed, 11 Oct 2023 19:06:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697051186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gFL/njcTU0yvkw4LErfuI7PHeqAkwfj0TqMCCeWSn1Q=; b=GyIAmnsjIb6hsCGsNL9brOetKxoNRbHHtpGzRMYZW+iP+eTWEVOzL4+rhqv+5Z8/G+rGmq 5TtvN+PHFeUOQ2WZd3gkDMFfl7z+5a8tPJg1mno2ygQyCJ47dEWdrptRnX2MxkaQXGAyV9 /uowwiDYHFyTq2gr6WQSOgWjJ+80XV2LQ2SguFOaH74JNMA3q73PDWzLlMVgQZTu715LA3 uTCoILV10xv8I/LRqr29iGF8LLGQoV2F+yt4B0j9r6i7gWxvDgPDq0ePrTkrFOksQPRs0A JvmQiF9WCjhJcCGbhs4Qlw/yoZr3tG8bsVtbM8WvxnZvZwBmWvMRoCsm+E7TEw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697051186; a=rsa-sha256; cv=none; b=IUDa+cSg16enA+CWVv5jDOt9wF9heItzrkCeWU4d3g2ngTxR5j7aHKmlNKAzrmF0KB4GkG 9uz59wZGSiYriMSA+WZ/nAZ+oukI2Bna5t/4DiY0+0xMeDmn6enAn4cra8BmXr9XA+XjFR tS807SbZDkb16mTq05hL06lB9B6l5NVs2GhjhoL9zNDgJOUQbr6kmRkvdKnxCOBY5h4RSz MVQpEX11jCzhi4xc3U/Wafp0bn4D+ZnHLov8DJEurFEwKTGd/ydrtIKiSnVAtIyDUtAUmp l2PTCJkgjMA37u2uVlDvYTzSn2TaY+QNFc6XYRQJE9RsCS2Jm77ZNOhcZZnoOA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697051186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gFL/njcTU0yvkw4LErfuI7PHeqAkwfj0TqMCCeWSn1Q=; b=lBiKLgvChq7YL3QU9RcAPe6jKxeTEegaHk8dLeUBJ+UKRqhhaOOYq4++5gnra7TONIg5pg YHYAqJBe4KV98kHs5T3VktWFBvXgiJFnRlxxhE1adY51FN5rnEvJ5pcpAa7EMePNy3Np3I 8eU/6GrVZMaRJ0Z76vdH39ytLM+V+mb1P6wgWvBEDqTY/Hch6X47ogwx6zGDKiwB+IoRJW DdSUDa0Cf74iXJaJ6WLjqgGURrx/FHlsz3WzrPipPZ72h8lVt9NZ3Im9+hlnkyAV5pIooo eclMKadOXW71LFBjv8Evw7175mC41aVqQ+f8vnC8Hhp41ugu3qAMq7upP6htxA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S5Mgk5kbrzYjG; Wed, 11 Oct 2023 19:06:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39BJ6QkV058757; Wed, 11 Oct 2023 19:06:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39BJ6Q15058754; Wed, 11 Oct 2023 19:06:26 GMT (envelope-from git) Date: Wed, 11 Oct 2023 19:06:26 GMT Message-Id: <202310111906.39BJ6Q15058754@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: e6dbc4dfd144 - stable/13 - efirt: Move comment about fpu_kern_enter to where it is called List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: e6dbc4dfd1444a38647fb55e9238112291b9e4cd Auto-Submitted: auto-generated The branch stable/13 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=e6dbc4dfd1444a38647fb55e9238112291b9e4cd commit e6dbc4dfd1444a38647fb55e9238112291b9e4cd Author: John Baldwin AuthorDate: 2023-08-25 19:33:00 +0000 Commit: John Baldwin CommitDate: 2023-10-11 15:09:52 +0000 efirt: Move comment about fpu_kern_enter to where it is called Reviewed by: imp, kib, andrew, markj Differential Revision: https://reviews.freebsd.org/D41576 (cherry picked from commit 8173fa60ddb7e9a805dec9fef7bf07e74ae4144d) --- sys/amd64/amd64/efirt_machdep.c | 5 ----- sys/dev/efidev/efirt.c | 5 +++++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/amd64/amd64/efirt_machdep.c b/sys/amd64/amd64/efirt_machdep.c index 4c6ee4ee88a2..5734e0300df8 100644 --- a/sys/amd64/amd64/efirt_machdep.c +++ b/sys/amd64/amd64/efirt_machdep.c @@ -280,11 +280,6 @@ fail: * reason to bother with the virtual map, and no need to add a * complexity into loader. * - * The fpu_kern_enter() call allows firmware to use FPU, as mandated - * by the specification. In particular, CR0.TS bit is cleared. Also - * it enters critical section, giving us neccessary protection against - * context switch. - * * There is no need to disable interrupts around the change of %cr3, * the kernel mappings are correct, while we only grabbed the * userspace portion of VA. Interrupts handlers must not access diff --git a/sys/dev/efidev/efirt.c b/sys/dev/efidev/efirt.c index 851385eeb8d6..29f51b78eb25 100644 --- a/sys/dev/efidev/efirt.c +++ b/sys/dev/efidev/efirt.c @@ -269,6 +269,11 @@ efi_rt_ok(void) return (0); } +/* + * The fpu_kern_enter() call in allows firmware to use FPU, as + * mandated by the specification. It also enters a critical section, + * giving us neccessary protection against context switches. + */ static int efi_enter(void) {