Date: Mon, 06 Jan 2014 15:22:05 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Jason Helfman <jgh@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r338802 - in head/textproc: docbook-241 docbook-300 docbook-310 docbook-400 docbook-410 docbook-440 docbook-450 docbook-500 docbook-xml-450 Message-ID: <646831BE6E0393D4F36AB5CC@ogg.in.absolight.net> In-Reply-To: <201401051721.s05HLNPn088802@svn.freebsd.org> <201401051728.s05HSamN089750@svn.freebsd.org> References: <201401051721.s05HLNPn088802@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
+--On 5 janvier 2014 17:21:23 +0000 Jason Helfman <jgh@FreeBSD.org> wrote:
| Log:
| - fix pkgname collisions
| -LATEST_LINK= docbook-241
| +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
| -LATEST_LINK= docbook-300
| +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
| -LATEST_LINK= docbook-310
| +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
| -LATEST_LINK= docbook-400
| +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
| -LATEST_LINK= docbook-410
| +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
| -LATEST_LINK= ${PORTNAME}-440
| +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
| -LATEST_LINK= ${PORTNAME}-450
| +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
| -LATEST_LINK= ${PORTNAME}-500
| +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
Why the overly complicated computation where you could just have put the
number that was in the LATEST_LINK right away ?
Those ports version will never change, so it's not likely that anyone will
ever have to update the PKGNAMESUFFIX.
| -LATEST_LINK= ${PORTNAME}-450
| +PKGNAMESUFFIX= ${PORTVERSION:S/.//}
| -LATEST_LINK= ${PORTNAME}-440
| +PKGNAMESUFFIX= ${PORTVERSION:S/.//}
And there, why the change of heart ? Now, we have a package named
docbook440 and one named docbook-xml44, which is rather not consistent at
all.
Regards,
--
Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?646831BE6E0393D4F36AB5CC>