From nobody Sun Jul 20 14:09:30 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4blQQ30hxRz629Br; Sun, 20 Jul 2025 14:09:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4blQQ26VPvz49qT; Sun, 20 Jul 2025 14:09:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753020570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kN3gMtH4lgxQeJfUZROny/mX4VC6MYMvCkxNMNbtyAM=; b=CErkP5wzEpLxZFwBNETmhNwoN5uN8GzopCRM9wlBj+b+/Xj4sNwDDrRV8beAmFYoHFPtBg P6eP4FK1exh+/2vaCfr5nj9Uowl2A1cjuIPI8MUADdCq6vHCVq8/6pFfPE/+Yns6WNLF1m oRdqOzGDmgEyS0fUQIQnGxc9Z6oJj5oJIzjKgpMNjOmWgN74Ym367JarD8T9XhsqwrqmEe kHOA9ZHdlnopk1eLqHfC+xdfPUzmHq8nHPIR9bW89G5UsBwpYM2cMQ9BrwJFumS421jBve Bop+1vHFE+2Ltkj0tr6pUJdztGzV55ChCZsjpPQWmPqI5YSnmy8rwRXYGn0VzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753020570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kN3gMtH4lgxQeJfUZROny/mX4VC6MYMvCkxNMNbtyAM=; b=jJYU+ISg+3Gj/pKgt6eYDKn4Akdg2j0Cv5z5nuIbr3M7Yr+bIZIjszxBpkmOt2Oslabgti 8lubOCOuo88u2GYs74ENYLEc4vAmSH5QPsW5u0F94qfSMky0PiSDxofm2khaAGTZLFOdNq E0NCurtW08x7YAmIFG4PHGeKveWhSsjIdzmVL54YZcpwLo1q8i2ykgwaq/NouxftmzGE2+ /Ur+u/5BjfupEohukrN8qAMMVv+3vLaOsNiqTqv7zEgiFya3PElbte8SZFO6m8da0mc5eO ZKM0vZofKlKdb94yiKhO5zxgo+sJa1hUT/AHpn7txT1mJBXUBQg4s/Y0Hlrr1A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753020570; a=rsa-sha256; cv=none; b=E/H7JvIYihbx53pkyTdIopEIVmVrOdEdjyhjwKUk35GLma72iQCVKLrhTFLGJAmtzXfocP hffDVJS5scO4pRiMqml7+KaYT2ucxxzIXdh7HXM7qXaSRdx+2l0BR+oO0zkdx4T0lFnsYi 5al/r68sjKyFmhjqkk7S3X1Oobye4/BH6bDOL1hSHdVT3gM0JQ2ugH3FfDp9WL82amP/ff VRQOILExxadus7AM20l8lTArsxnwboPbgh7Dg/gj7fD2a7Gq0a2WIdoOIWerp7wYVFAVrw L8BRrfzu3OeorYjZHNB1f7mlB2uw3A5UrqVQetidPqPk8+MbpDRxiBvPRr/oIg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4blQQ25g6fz19M; Sun, 20 Jul 2025 14:09:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56KE9UZ1040547; Sun, 20 Jul 2025 14:09:30 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56KE9UU2040543; Sun, 20 Jul 2025 14:09:30 GMT (envelope-from git) Date: Sun, 20 Jul 2025 14:09:30 GMT Message-Id: <202507201409.56KE9UU2040543@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: 8ef7ad95e915 - stable/14 - qlnx: fix panic at startup List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 8ef7ad95e9156bea689274c9d57fc961b203efe2 Auto-Submitted: auto-generated The branch stable/14 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=8ef7ad95e9156bea689274c9d57fc961b203efe2 commit 8ef7ad95e9156bea689274c9d57fc961b203efe2 Author: Kristof Provost AuthorDate: 2025-06-12 16:53:33 +0000 Commit: Zhenlei Huang CommitDate: 2025-07-20 14:07:19 +0000 qlnx: fix panic at startup While attaching the qlnx driver we can end up trying to call ifmedia functions before those are set up (through ether_ifattach() -> rtnl_handle_ifattach() -> dump_iface() -> get_operstate_ether() -> ifmedia_ioctl()). Postpone the ether_ifattach() until after the ifmedia setup. Reviewed by: markj,zlei Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D50819 (cherry picked from commit 4f7473d18a62077a218ac00817bae09a95b8cbcb) --- sys/dev/qlnx/qlnxe/qlnx_os.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index 49d3f20aa0c2..fefddcbc3cea 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2339,9 +2339,6 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) ha->primary_mac[5] = (rnd >> 16) & 0xFF; } - ether_ifattach(ifp, ha->primary_mac); - bcopy(if_getlladdr(ha->ifp), ha->primary_mac, ETHER_ADDR_LEN); - if_setcapabilities(ifp, IFCAP_HWCSUM); if_setcapabilitiesbit(ifp, IFCAP_JUMBO_MTU, 0); @@ -2396,6 +2393,9 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) ifmedia_set(&ha->media, (IFM_ETHER | IFM_AUTO)); + ether_ifattach(ifp, ha->primary_mac); + bcopy(if_getlladdr(ha->ifp), ha->primary_mac, ETHER_ADDR_LEN); + QL_DPRINT2(ha, "exit\n"); return;