From owner-freebsd-ports  Sat Apr 10 23:52:15 1999
Delivered-To: freebsd-ports@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 20EA014BDC
	for <freebsd-ports@FreeBSD.org>; Sat, 10 Apr 1999 23:52:14 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.2/8.9.2) id XAA91331;
	Sat, 10 Apr 1999 23:50:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Date: Sat, 10 Apr 1999 23:50:01 -0700 (PDT)
Message-Id: <199904110650.XAA91331@freefall.freebsd.org>
To: freebsd-ports@FreeBSD.org
Cc: 
From: Michael Haro <mharo@area51.fremont.ca.us>
Subject: Re: ports/11076: New port: cmp3
Reply-To: Michael Haro <mharo@area51.fremont.ca.us>
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

The following reply was made to PR ports/11076; it has been noted by GNATS.

From: Michael Haro <mharo@area51.fremont.ca.us>
To: cpiazza@home.net, freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: ports/11076: New port: cmp3
Date: Sat, 10 Apr 1999 23:44:01 -0700

 After a quick runthrough this is what I find...
 
 diff -u -urN -x CVS cmp3/Makefile cmp3.new/Makefile
 --- cmp3/Makefile	Sat Apr 10 23:38:02 1999
 +++ cmp3.new/Makefile	Sat Apr 10 23:39:42 1999
 @@ -15,20 +15,19 @@
  
  RUN_DEPENDS= 	mpg123:${PORTSDIR}/audio/mpg123
  
 -USE_GMAKE=	YES
 +USE_GMAKE=	yes
  
  WRKSRC=	${WRKDIR}/cmp3
  
  do-install:
  	${INSTALL_PROGRAM} ${WRKSRC}/cmp3 ${PREFIX}/bin
  	${INSTALL_PROGRAM} ${WRKSRC}/rnmp3 ${PREFIX}/bin
 -	${MKDIR} ${PREFIX}/share/cmp3
 -	${INSTALL_DATA} ${WRKSRC}/README ${PREFIX}/share/cmp3
 +.if !defined(NOPORTDOCS)
 +	${MKDIR} ${PREFIX}/share/doc/cmp3
 +	${INSTALL_DATA} ${WRKSRC}/README ${PREFIX}/share/doc/cmp3
 +.endif
  
  post-install:
 -	@${ECHO_MSG} "*****NOTE*****"
 -	@${ECHO_MSG} "Please read ${PREFIX}/share/cmp3/README before \
 -		      using cmp3"
 -	@${ECHO_MSG} "*****NOTE*****" 
 +	@${CAT} ${PKGDIR}/MESSAGE
  
  .include <bsd.port.mk>
 diff -u -urN -x CVS cmp3/patches/patch-aa cmp3.new/patches/patch-aa
 --- cmp3/patches/patch-aa	Sat Apr 10 23:38:03 1999
 +++ cmp3.new/patches/patch-aa	Sat Apr 10 23:28:00 1999
 @@ -1,5 +1,23 @@
  --- Makefile.orig	Sat Apr 10 12:40:57 1999
 -+++ Makefile	Sat Apr 10 22:21:27 1999
 ++++ Makefile	Sat Apr 10 23:26:31 1999
 +@@ -1,7 +1,7 @@
 + #
 + #  Set these variables
 + #
 +-INIT_DIR="/mp3"
 ++INIT_DIR="$(PREFIX)/share/mp3"
 + MPG123_LOC="mpg123"
 + #INSTALL_DIR=/usr/local/bin
 + INSTALL_DIR=$(HOME)/bin
 +@@ -11,7 +11,7 @@
 + #
 + 
 + ## An ass repository is a nice thing to have. See README
 +-ASSREPOSITORY="$(HOME)/.cmp3ass"
 ++#ASSREPOSITORY="$(HOME)/.cmp3ass"
 + 
 + ## Define this for bufferring or add other parameters to mpg123
 + #EXEC_PARAMS=-DEXEC_PARAMS="\"-b\",\"320\""
  @@ -30,8 +30,9 @@
   # stands. Change the code to do something else you want it to do...
   #PARAMS +=-DMY_CD
 @@ -7,7 +25,7 @@
  -CFLAGS= -Wall -O2 -g
  -CC= gcc
  +CFLAGS?= -O2
 -+CFLAGS+= -Wall -g
 ++CFLAGS+= -Wall
  +CC?= gcc
   OBJS= llist.o cmp3fileio.o cmp3manager.o cmp3curses.o cmp3llist.o \
         cmp3main.o cmp3listfiles.o cmp3playlist.o
 @@ -20,3 +38,7 @@
   
   clean: 
   	rm -f *.o *~ DEADJOE core cmp3 rnmp3
 +@@ -75,4 +75,4 @@
 + 	    fi;
 + endif
 + 
 diff -u -urN -x CVS cmp3/pkg/MESSAGE cmp3.new/pkg/MESSAGE
 --- cmp3/pkg/MESSAGE	Wed Dec 31 16:00:00 1969
 +++ cmp3.new/pkg/MESSAGE	Sat Apr 10 23:00:51 1999
 @@ -0,0 +1,3 @@
 +*****NOTE*****
 +Please read ${PREFIX}/share/cmp3/README before using cmp3
 +*****NOTE*****
 diff -u -urN -x CVS cmp3/pkg/PLIST cmp3.new/pkg/PLIST
 --- cmp3/pkg/PLIST	Sat Apr 10 23:38:03 1999
 +++ cmp3.new/pkg/PLIST	Sat Apr 10 23:30:04 1999
 @@ -1,4 +1,4 @@
  bin/cmp3
  bin/rnmp3
 -share/cmp3/README
 -@dirrm share/cmp3
 +share/doc/cmp3/README
 +@dirrm share/doc/cmp3
 
 Michael
 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message