From owner-svn-src-all@FreeBSD.ORG Tue Jan 20 12:30:31 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A44BB106567F; Tue, 20 Jan 2009 12:30:31 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id 461E78FC25; Tue, 20 Jan 2009 12:30:31 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1LPFkT-0002DO-Lw; Tue, 20 Jan 2009 14:30:29 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id n0KCUNo4097271 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 20 Jan 2009 14:30:23 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id n0KCUNv4011626; Tue, 20 Jan 2009 14:30:23 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id n0KCUMsL011625; Tue, 20 Jan 2009 14:30:22 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 20 Jan 2009 14:30:22 +0200 From: Kostik Belousov To: Roman Divacky Message-ID: <20090120123022.GB58517@deviant.kiev.zoral.com.ua> References: <200901201130.n0KBUM01043886@svn.freebsd.org> <20090120115233.GA43828@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="K8nIJk4ghYZn606h" Content-Disposition: inline In-Reply-To: <20090120115233.GA43828@freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1LPFkT-0002DO-Lw 62e3c7124d0766103d60a637b5db5861 X-Terabit: YES Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187468 - head/sys/ufs/ffs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2009 12:30:32 -0000 --K8nIJk4ghYZn606h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 20, 2009 at 12:52:33PM +0100, Roman Divacky wrote: > On Tue, Jan 20, 2009 at 11:30:22AM +0000, Konstantin Belousov wrote: > > Author: kib > > Date: Tue Jan 20 11:30:22 2009 > > New Revision: 187468 > > URL: http://svn.freebsd.org/changeset/base/187468 > >=20 > > Log: > > When extending inode size, we call vnode_pager_setsize(), to have a > > address space where to put vnode pages, and then call UFS_BALLOC(), > > to actually allocate new block and map it. When UFS_BALLOC() returns > > error, sometimes we forget to revert the vm object size increase, > > allowing for the pages that are not backed by the logical disk blocks. > > =20 > > Revert vnode_pager_setsize() back when UFS_BALLOC() failed, for > > ffs_truncate() and ffs_write(). >=20 > can you describe in what scenario this can trigger? can it be that > many smallish (a few tens of kB?) of mmaped files being read/write > may cause this? The usual scenario is either a full partition or exceeded block quotas for the user that writes the file and then mmap it. --K8nIJk4ghYZn606h Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkl1w90ACgkQC3+MBN1Mb4iyHACfSP8J1KUPlxC2ujeEMrrI20El VLUAnitW3DyAtfIJt0uGl5gMRsaag9Ne =5Yfo -----END PGP SIGNATURE----- --K8nIJk4ghYZn606h--