From owner-svn-ports-head@freebsd.org Tue Jul 2 07:03:34 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F0B5C15C9DC9; Tue, 2 Jul 2019 07:03:33 +0000 (UTC) (envelope-from freebsd@toco-domains.de) Received: from toco-domains.de (mail.toco-domains.de [IPv6:2a01:4f8:151:4202::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 035637102C; Tue, 2 Jul 2019 07:03:31 +0000 (UTC) (envelope-from freebsd@toco-domains.de) Received: by toco-domains.de (Postfix, from userid 65534) id AC13893D98; Tue, 2 Jul 2019 09:03:29 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on toco-mail X-Spam-Level: X-Spam-Status: No, score=-2.9 required=4.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from [192.168.1.6] (x4e30305b.dyn.telefonica.de [78.48.48.91]) by toco-domains.de (Postfix) with ESMTPA id 3B4AE93D8A; Tue, 2 Jul 2019 09:03:26 +0200 (CEST) Subject: Re: svn commit: r505245 - in head/databases: postgresql10-client postgresql10-contrib postgresql10-pgtcl postgresql10-server postgresql11-client postgresql11-server postgresql94-server postgresql95-cli... To: Alexey Dokuchaev , Matthias Fechner Cc: Palle Girgensohn , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201906272128.x5RLS0Uv072609@repo.freebsd.org> <899f2367-828a-9eca-dfaa-e34a039fcdac@toco-domains.de> <20190629155606.GB97932@FreeBSD.org> <6ff9ed1f-1597-bc72-6ed2-e0bb634af8f7@fechner.net> <20190630091359.GB59213@FreeBSD.org> From: Torsten Zuehlsdorff Openpgp: preference=signencrypt Message-ID: Date: Tue, 2 Jul 2019 09:03:26 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190630091359.GB59213@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 035637102C X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of freebsd@toco-domains.de designates 2a01:4f8:151:4202::3 as permitted sender) smtp.mailfrom=freebsd@toco-domains.de X-Spamd-Result: default: False [-3.90 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[toco-domains.de]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[mail.toco-domains.de]; NEURAL_HAM_SHORT(-0.83)[-0.825,0]; IP_SCORE(-0.77)[ipnet: 2a01:4f8::/29(-2.05), asn: 24940(-1.78), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jul 2019 07:03:34 -0000 On 30.06.19 11:13, Alexey Dokuchaev wrote: > On Sat, Jun 29, 2019 at 07:14:11PM +0200, Matthias Fechner wrote: >> Am 29.06.2019 um 17:56 schrieb Alexey Dokuchaev: >>> We're using Postres in our production at $work and had to carefully evaluate >>> all 9.x versions, so it looks strange the GitLab works with 9.6 but not with >>> 9.5, as changes between these should be pretty minor AFAIR (in comparison to >>> e.g. 9.3). May we know what exactly breaks, so maybe we can craft a patch >>> to fix it? >> >> I do not fully remember what it was, but they use a feature that was >> added with 9.6 (used to retrieve data from the database with a more >> complex query): >> https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/install/requirements.md#postgresql-requirements >> >> If you would like to have more details, there is an issue existing that >> describe why 9.6 is required in detail, but I do not have the link anymore. >> Maybe it is easier to check what new feature was added with 9.6. > > I tried to see what had changed but could only find version bump from 9.2 > to 9.6 in commits like these: > > https://gitlab.com/gitlab-org/gitlab-ce/commit/b609c8f650ca9854d12edbf623f2419c216e73a7 > https://gitlab.com/gitlab-org/gitlab-ce/commit/e1294022875138b40db7d34a9f33ac9f4a7dc655 > > I'd try to lower those number to 9.5, I'd expect with high probability > things would work just as fine. It depends on the features you use. PostgreSQL 9.6 was declared as mandatory for GitLab 12.0 because of the Geo Feature. If you don't use this feature, things will still work fine. Also as far as i recall there are some performance improvements only available for Users of 9.6+. >> So we should not block here to go to a more recent version. > > Yeah, which is, like, 10.x. :-) I will aim for 11. PostgreSQL 12 will be released around September 2019. This will make 9.5 unsupported and 9.6 the oldest supported release with its EOL next year. >From our point of view there is no big difference in the work needed. There is a break in FreeBSD PostgreSQL usage beginning with 9.6. This is because of the switch of the standard PostgreSQL user and data-dirs per version. So there is no difference in picking 9.6, 10 or 11. I set the change on my todo list. If somebody else want to do it, just notice me. Otherwise i will go ahead. Greetings, Torsten