From owner-freebsd-scsi Mon Jan 24 9:10:54 2000 Delivered-To: freebsd-scsi@freebsd.org Received: from feral.com (feral.com [192.67.166.1]) by hub.freebsd.org (Postfix) with ESMTP id 1E2D215A9B for ; Mon, 24 Jan 2000 09:10:50 -0800 (PST) (envelope-from mjacob@feral.com) Received: from beppo.feral.com (beppo [192.67.166.79]) by feral.com (8.9.3/8.9.3) with ESMTP id JAA23683; Mon, 24 Jan 2000 09:10:46 -0800 Date: Mon, 24 Jan 2000 09:10:43 -0800 (PST) From: Matthew Jacob Reply-To: mjacob@feral.com To: Nick Hibma Cc: FreeBSD SCSI Mailing List Subject: Re: bug in cam_periph.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Mon, 24 Jan 2000, Nick Hibma wrote: > > I found the code while implementing the autosense in software in the > umass driver. This is true for the vpo driver as well. > > You are basically saying that we could implement the sense command > there. Except that of course for example from scsi_da.c that generic > routine is never called. It relies on autosense I believe. Not 'could'- 'should'. Right now we have to have all sim drivers implement autosense their own way- big PITA if not done in H/W-F/W. Even drivers that normally could do autosense can't always do so. The Qlogic 2X00 Fibre Channel card is one example- if the target doesn't set Sense Valid in the FCP Response, the 2X00 won't automatically run a REQUEST SENSE to fill in the needed sense data if the scsi status was CHECK CONDITION- unlike the parallel SCSI versions from the same vendor. Not *usually* a problem because it's usually set and filled in, but there are cases where it isn't (look at FreeBSD's own scsi_target.c as an example). It's possible that periph_error isn't the right place to do this, but it's probably the best place to do this. -matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message