From owner-freebsd-scsi@FreeBSD.ORG Mon Nov 20 03:06:19 2006 Return-Path: X-Original-To: freebsd-scsi@freebsd.org Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 995DA16A403; Mon, 20 Nov 2006 03:06:19 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id E112D43D7D; Mon, 20 Nov 2006 03:06:03 +0000 (GMT) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.13.8/8.13.8) with ESMTP id kAK3667a049839; Sun, 19 Nov 2006 19:06:16 -0800 (PST) (envelope-from mjacob@freebsd.org) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.13.8/8.13.8/Submit) with ESMTP id kAK365ST049836; Sun, 19 Nov 2006 19:06:06 -0800 (PST) (envelope-from mjacob@freebsd.org) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Sun, 19 Nov 2006 19:06:05 -0800 (PST) From: mjacob@freebsd.org X-X-Sender: mjacob@ns1.feral.com To: Scott Long In-Reply-To: <456101EF.1070609@samsco.org> Message-ID: <20061119190530.K49835@ns1.feral.com> References: <20061119161631.L44297@ns1.feral.com> <3bbf2fe10611191631h6883b862uf8088533913a7bc6@mail.gmail.com> <20061119164455.I44297@ns1.feral.com> <3bbf2fe10611191657gaaf90ecyd6ac3e41ae59992f@mail.gmail.com> <20061119170554.K45489@ns1.feral.com> <456101EF.1070609@samsco.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Attilio Rao , freebsd-scsi@freebsd.org Subject: Re: a code reduction function addition to cam_xpt X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mjacob@freebsd.org List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Nov 2006 03:06:19 -0000 > mjacob@freebsd.org wrote: >> >>> Erm, we make large use of variadic macros into the code :) >> >> Yes. I think that if the code is never going to get backported to FBSD5 or >> earlier, it's probably fair enough to use, but for the aesthetics. > > You mean FreeBSD 4 or FreeBSD 5? CAM is about to be pretty unportable back > to FreeBSD 4 for other reasons. Ah, err, large chunks of it *do* go back.