From owner-cvs-all Thu Apr 11 14:51:26 2002 Delivered-To: cvs-all@freebsd.org Received: from fw.wemm.org (12-232-135-171.client.attbi.com [12.232.135.171]) by hub.freebsd.org (Postfix) with ESMTP id 5FCC137B404; Thu, 11 Apr 2002 14:51:16 -0700 (PDT) Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3]) by fw.wemm.org (8.11.6/8.11.6) with ESMTP id g3BLpGQ29954; Thu, 11 Apr 2002 14:51:16 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (Postfix) with ESMTP id 20D553810; Thu, 11 Apr 2002 14:51:17 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: obrien@FreeBSD.org Cc: Ruslan Ermilov , Marcel Moolenaar , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/gnu/usr.bin/gperf Makefile src/gnu/usr.bin/groff/src/devices/grodvi Makefile src/gnu/usr.bin/groff/src/devices/grohtml Makefile src/gnu/usr.bin/groff/src/devices/grolbp Makefile sr In-Reply-To: <20020411135740.A13856@dragon.nuxi.com> Date: Thu, 11 Apr 2002 14:51:17 -0700 From: Peter Wemm Message-Id: <20020411215117.20D553810@overcee.wemm.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "David O'Brien" wrote: > On Thu, Apr 11, 2002 at 12:33:53PM +0300, Ruslan Ermilov wrote: > > +.if defined(PROG_CXX) > > +PROG= ${PROG_CXX} > > +DPADD+= ${LIBSTDCPLUSPLUS} > > +LDADD+= -lstdc++ > > +.endif > > We really should not be doing this part -- we do not do it for libc. > Making too many assumptions about how G++ expects the linking to be is > bad. Rather if PROG_GXX is set, 'g++' should be used for linking rather > than 'gcc' [as Peter mentioned]. We really should just be letting g++ do > its job. That's what I did, except I used c++. (we use "cc" not "gcc", we shouldn't use "g++" either). The main point is that this can be changed behind the scenes without affecting the groff/gperf makefiles anymore. This is now an implementation detail. I can finish my build testing and commit the stuff that uses c++ etc to do the final link. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message