From owner-cvs-all  Wed Jul 17 20: 6:17 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 889C737B400; Wed, 17 Jul 2002 20:06:12 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4043B43E4A; Wed, 17 Jul 2002 20:06:11 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id NAA17541;
	Thu, 18 Jul 2002 13:06:04 +1000
Date: Thu, 18 Jul 2002 13:09:51 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Andrew Gallatin <gallatin@cs.duke.edu>
Cc: John Baldwin <jhb@FreeBSD.org>, <cvs-all@FreeBSD.org>,
	<cvs-committers@FreeBSD.org>
Subject: RE: cvs commit: src/sys/kern kern_condvar.c kern_shutdown.c kern
In-Reply-To: <15669.27952.598634.585316@grasshopper.cs.duke.edu>
Message-ID: <20020718130618.N7388-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Wed, 17 Jul 2002, Andrew Gallatin wrote:

> Bruce Evans writes:
> In terms of bitrot removal in the comments, would the removal of the
> second sentence of the following comment in both msleep() and its
> clone in cv_timedwait() be sufficient?
>
>
>         /*
>                  * During autoconfiguration, just give interrupts
>                  * a chance, then just return.
>                  * Don't run any other procs or panic below,
>                  * in case this is the idle process and already asleep.
>          */
>
>
> Becomes:
>
>         /* During autoconfiguration, just return */
>

I've left caveats about this in my version until the problems are fully
understood.  I would prefer a KASSERT that this code is not reached.

%%%
Index: kern_synch.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/kern_synch.c,v
retrieving revision 1.185
diff -u -1 -r1.185 kern_synch.c
--- kern_synch.c	14 Jul 2002 03:43:33 -0000	1.185
+++ kern_synch.c	17 Jul 2002 12:31:32 -0000
@@ -482,5 +574,9 @@
 		 * After a panic, or during autoconfiguration,
-		 * just give interrupts a chance, then just return;
+		 * then just return;
 		 * don't run any other procs or panic below,
 		 * in case this is the idle process and already asleep.
+		 * XXX: this used to do "s = splhigh(); splx(safepri);
+		 * splx(s);" to give interrupts a chance, but there is
+		 * no way to give interrupts a chance now.
+		 * XXX2: this can't be the idle process.
 		 */
%%%

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message