From owner-svn-src-head@FreeBSD.ORG  Tue Mar  4 23:18:01 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 73A50FA2;
 Tue,  4 Mar 2014 23:18:01 +0000 (UTC)
Received: from vps.hungerhost.com (vps.hungerhost.com [216.38.53.176])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 44BE5AC1;
 Tue,  4 Mar 2014 23:18:00 +0000 (UTC)
Received: from pool-96-250-5-187.nycmny.fios.verizon.net ([96.250.5.187]:63391
 helo=minion.home)
 by vps.hungerhost.com with esmtpsa (TLSv1:AES128-SHA:128)
 (Exim 4.80.1) (envelope-from <gnn@freebsd.org>)
 id 1WKyb1-0005tA-9K; Tue, 04 Mar 2014 18:17:59 -0500
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\))
Subject: Re: svn commit: r262727 - head/sys/net
From: George Neville-Neil <gnn@freebsd.org>
In-Reply-To: <201403041214.44230.jhb@freebsd.org>
Date: Tue, 4 Mar 2014 18:17:57 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <FD8EBD57-749C-4247-8CA2-E846E046476F@freebsd.org>
References: <201403040509.s2459lou017310@svn.freebsd.org>
 <201403041214.44230.jhb@freebsd.org>
To: John Baldwin <jhb@FreeBSD.org>
X-Mailer: Apple Mail (2.1874)
X-AntiAbuse: This header was added to track abuse,
 please include it with any abuse report
X-AntiAbuse: Primary Hostname - vps.hungerhost.com
X-AntiAbuse: Original Domain - freebsd.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - freebsd.org
X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id:
 gnn@neville-neil.com
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Mar 2014 23:18:01 -0000


On Mar 4, 2014, at 12:14 , John Baldwin <jhb@FreeBSD.org> wrote:

> On Tuesday, March 04, 2014 12:09:47 am George V. Neville-Neil wrote:
>> Author: gnn
>> Date: Tue Mar  4 05:09:46 2014
>> New Revision: 262727
>> URL: http://svnweb.freebsd.org/changeset/base/262727
>>=20
>> Log:
>>  Naming consistency fix. The routing code defines
>>  RADIX_NODE_HEAD_LOCK as grabbing the write lock,
>>  but RADIX_NODE_HEAD_LOCK_ASSERT as checking the read lock.
>=20
> Actually, that isn't what RA_LOCKED means.  RA_LOCKED means that it is
> either read- or write-locked.  Note that you have now made=20
> RADIX_NODE_HEAD_LOCK_ASSERT() a redundant copy of=20
> RADIX_NODE_HEAD_WLOCK_ASSERT().  You should revert that part in some
> way (either remove HEAD_LOCK_ASSERT() entirely leaving just =
RLOCK_ASSERT() and=20
> WLOCK_ASSERT(), or restore HEAD_LOCK_ASSERT() to using RA_LOCKED if =
there are=20
> places that want to assert that the lock is held, but don't care if it =
is read=20
> or write).

Actually I=92ll revert the whole thing and to back to Vijay to rework =
this.

Best,
George