From owner-freebsd-wireless@FreeBSD.ORG Wed Aug 24 02:39:53 2011 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 89728106566B; Wed, 24 Aug 2011 02:39:53 +0000 (UTC) (envelope-from paradyse@gmail.com) Received: from mail-yi0-f54.google.com (mail-yi0-f54.google.com [209.85.218.54]) by mx1.freebsd.org (Postfix) with ESMTP id 32EC38FC18; Wed, 24 Aug 2011 02:39:52 +0000 (UTC) Received: by yib19 with SMTP id 19so675415yib.13 for ; Tue, 23 Aug 2011 19:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=BWrJJLyOy5KDMLaSOM823iDeciDQ4OLDR9+ZBa2ngkY=; b=b/bSt02dEmdNPCTaxlcEH7wx+TloJkJKeu6KqytpIR1nxlo+QyV9R9OF40GyMOOW8Y 6sc3dm5yFvuBwTOg/PyeLC/hUV8qWyUDVWQVkdmKf2dH3pUc0MwR22y6TPQEmvZlKh7n 8M/A/PTbQpTglGwVDIpTTiCt+paqBOBCT5VcA= Received: by 10.151.99.17 with SMTP id b17mr1445318ybm.252.1314153592139; Tue, 23 Aug 2011 19:39:52 -0700 (PDT) MIME-Version: 1.0 Sender: paradyse@gmail.com Received: by 10.151.43.7 with HTTP; Tue, 23 Aug 2011 19:39:32 -0700 (PDT) In-Reply-To: References: From: Kang Yin Su Date: Wed, 24 Aug 2011 10:39:32 +0800 X-Google-Sender-Auth: -Y6D0hV9CHtkTiWfdOKPRQ7a-bQ Message-ID: To: Adrian Chadd Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-wireless@freebsd.org Subject: Re: AR5416 beacon issue. X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2011 02:39:53 -0000 On Tue, Aug 23, 2011 at 9:23 PM, Adrian Chadd wrote: > Hi! > > On 23 August 2011 17:37, Kang Yin Su wrote: > > Hi all, > > OK, this patch fix the beacons sequence number from AR5416 chips. With > this > > code added, both beacons send from AR5212 and AR5416 chips are fine, the > > sequence numbers are increase by 1. I have no idea why the AR5212 chips > do > > not this require this. The AR5212 hardware probably ignore this field and > > added the seq no. by itself? > > Can you just verify that both the TDMA and non-TDMA beacon send code > in ath(4) actually generates a new beacon each time, and thus will > -get- an updated sequence number? > > Both the TDMA and non-TDMA call ath_beacon_generate() before TX beacon. See below: I'm worried that the current ath(4) beacon code only fires off a new > beacon to the hardware if the beacon contents needed changing, and > just re-uses the same frame over and over, expecting the hardware to > bump the sequence number. > > Disabled REG_PRESERVE_SEQNUM. Hardware bump the beacon sequence number without the software sequence number fix in net80211 layer. Enable REG_PRESERVE_SEQNUM (thats in ar5416 hal currently), you need my sequence number fix in net80211. That's what I tested and mentioned yesterday. So the hardware sequence should work. Would you mind checking for me? :) > > Thanks, > > > Adrian Please let me know if that is what you concern and anything want to test. Thanks, Yin