From owner-svn-src-head@freebsd.org Sat Aug 29 00:56:40 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F26223C8D00; Sat, 29 Aug 2020 00:56:39 +0000 (UTC) (envelope-from dch@skunkwerks.at) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BddMW5fqcz3Sjf; Sat, 29 Aug 2020 00:56:39 +0000 (UTC) (envelope-from dch@skunkwerks.at) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 3798DD62; Fri, 28 Aug 2020 20:56:38 -0400 (EDT) Received: from imap6 ([10.202.2.56]) by compute4.internal (MEProxy); Fri, 28 Aug 2020 20:56:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skunkwerks.at; h=mime-version:message-id:in-reply-to:references:date:from:to :cc:subject:content-type; s=fm3; bh=trFl0u5sLPAMoRyc+dhtAkadJE1f /G1twBoqufs9boA=; b=Jdd4MkhcxcYGz/3eZTU67lFUtHBIMFjmQ8VhdkFxYwOP tZ3l8MX/glaBIMXeYicd5Il1aJpJrKawAiSnjFn30gbhv00k35CZK8x/nFmP08ht Cu0JGV4Cti2YIAASvdFRMbvny7oDkFTn37mbRGNpNDUzA6WKw6e6KT67iA4iLz2Z gMhp2hOE47BGliht96mmjQxoaVNRzbW+CxDQDNnTBvbDQ3NZpJ0Yhfn3VMq5ZVaX EIUOt80MpSMt8QO3q3kFvuzu2xmR5btdiXMLd67WTRgLPAyuksObWS56+D/WqTL1 rAR/8tlqMrAI3UXs/iQC/fAXqi6unYhwekUmwkBwzQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=trFl0u 5sLPAMoRyc+dhtAkadJE1f/G1twBoqufs9boA=; b=Chxc5bw5MMZOjIlZ3x3mG0 KYLX+WLOroKAaAO6NDqXY0WCjSBOJcp5cXWcCw0eA7CbD8VnIIfNEMQ7ChTZwEhw 2GM/3ThICQK2+5prgNzyhOylymjsyWAtkmWDVFbPNgeq2oBVWhQhfNHSVCJQoaJ9 KzB5Spr8g0PHCJ2ZLgEST+jvhl5CFbvtKTuzjmT63BnjLfB9JuAdDUlB0BYQ7fw2 CCoDXJIX3LuAHFc8UZzAGREuKeFyhyLbECfwjPiXw9yqSArIDnPrbVTk6yegBNi5 xiprdiY0yZ90EwXUqjQT8F/w3LPptzMG5PVFzHiyCzkptQsncJF5Ea74fBdMdn/A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudeftddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtsehttd ertderredtnecuhfhrohhmpedfffgrvhgvucevohhtthhlvghhuhgsvghrfdcuoegutghh sehskhhunhhkfigvrhhkshdrrghtqeenucggtffrrghtthgvrhhnpedvteeljefhveetie egfeeggeetjeeiffdufedviedvgfetieehgfeugffghfekheenucffohhmrghinhepfhhr vggvsghsugdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegutghhsehskhhunhhkfigvrhhkshdrrght X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id C728B1400A1; Fri, 28 Aug 2020 20:56:36 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-232-g4bdb081-fm-20200825.002-g4bdb081a Mime-Version: 1.0 Message-Id: <98502308-cc22-4819-87be-2acccd71e0a4@www.fastmail.com> In-Reply-To: <202008281825.07SIPkBa029646@repo.freebsd.org> References: <202008281825.07SIPkBa029646@repo.freebsd.org> Date: Sat, 29 Aug 2020 00:56:16 +0000 From: "Dave Cottlehuber" To: "Emmanuel Vadot" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364927 - head/sys/arm/allwinner/clkng Content-Type: text/plain X-Rspamd-Queue-Id: 4BddMW5fqcz3Sjf X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:11403, ipnet:64.147.123.0/24, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Aug 2020 00:56:40 -0000 On Fri, 28 Aug 2020, at 18:25, Emmanuel Vadot wrote: > Author: manu > Date: Fri Aug 28 18:25:45 2020 > New Revision: 364927 > URL: https://svnweb.freebsd.org/changeset/base/364927 > > Log: > arm: allwinner: clk: Add printfs when we cannot set the correct freq > > For some unknown reason this seems to fix this function when we printf > the best variable. This isn't a delay problem as doing a printf without > it doesn't solve this problem. > This is way above my pay grade so add some printf that shouldn't be printed > in 99% of the case anyway. > Fix booting on most Allwinner boards as the mmc IP uses a NM clock. > > Reported by: Alexander Mishin > MFC after: 3 days > X-MFC-With: 363887 > > Modified: > head/sys/arm/allwinner/clkng/aw_clk_nm.c > > Modified: head/sys/arm/allwinner/clkng/aw_clk_nm.c > ============================================================================== > --- head/sys/arm/allwinner/clkng/aw_clk_nm.c Fri Aug 28 17:55:54 2020 (r364926) > +++ head/sys/arm/allwinner/clkng/aw_clk_nm.c Fri Aug 28 18:25:45 2020 (r364927) > @@ -221,11 +221,15 @@ aw_clk_nm_set_freq(struct clknode *clk, uint64_t fpare > if ((best < *fout) && > ((flags & CLK_SET_ROUND_DOWN) == 0)) { > *stop = 1; > + printf("best freq (%llu) < requested freq(%llu)\n", Salut Manu, Fails to build on aarch64 unless this is reverted, or I use printf("best freq (%lu) < requested freq(%lu)\n", > + best, *fout); > return (ERANGE); > } > if ((best > *fout) && > ((flags & CLK_SET_ROUND_UP) == 0)) { > *stop = 1; > + printf("best freq (%llu) > requested freq(%llu)\n", & again printf("best freq (%lu) > requested freq(%lu)\n", A+ Dave -------------------------------------------------------------- >>> stage 3.1: building everything -------------------------------------------------------------- /usr/src/sys/arm/allwinner/clkng/aw_clk_nm.c:225:7: error: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Werror,-Wformat] best, *fout); ^~~~ /usr/src/sys/arm/allwinner/clkng/aw_clk_nm.c:225:13: error: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Werror,-Wformat] best, *fout); ^~~~~ /usr/src/sys/arm/allwinner/clkng/aw_clk_nm.c:232:7: error: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Werror,-Wformat] best, *fout); ^~~~ /usr/src/sys/arm/allwinner/clkng/aw_clk_nm.c:232:13: error: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Werror,-Wformat] best, *fout); ^~~~~ 4 errors generated. --- aw_clk_nm.o --- *** [aw_clk_nm.o] Error code 1