From nobody Mon Apr 10 13:08:44 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pw8Rw5xkrz44F0M; Mon, 10 Apr 2023 13:08:44 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pw8Rw4qcNz3Dd0; Mon, 10 Apr 2023 13:08:44 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681132124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8EX56W1As3D8aqwsfOo6NBqCfjk4rpZ6dnp3OMoC6fY=; b=b/wQy+bKhppHdn/5SZKmiFa11zGF1t2z+KKseLBsJE+pWArYItuEflHgMwDVQiaRQrV1yg Wfp3R40G3dCeBRqxQhf1E0krapEVmri2uoC0lyDzaw0IhkPWHzHfrfHufNFN34UYmPk3mx ZSm7o4ZOXCkegCz9OJPctyYXvSD2qGbz6hP0hOdUkH13OPije9ZKhdXN6g9GJvg41SovLd YQZIoSplcbzhbfZKDdDGlnKEKAOz4Bg0FMjC/K+EvnKC/mbJaVB7W1C/mR+9DQbT1RCfeS X3nPpyO+Syh/8/U11ItN+BrZq6YMOceA/BX5m1/5lrzxin5s7EJYyKL1geCp2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681132124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8EX56W1As3D8aqwsfOo6NBqCfjk4rpZ6dnp3OMoC6fY=; b=ifqUkccSMQB/Np5v29AkdPh+O1YfJMnwyV8m6l65UkE59qhOrBVx9RLchO5qYZMI/TxQt8 P7cTeUphC+hCzopLzHbZfQ9OVuoeGyGfShy1OfVNt4hcxlyk7/RoO9PZ+bmiAVgJSPqbki XDtXeSfHwZ15V6vkQS0vPhVivOMNld429tJxtOkkIO/2IxU844aeDtsqY9kcinVWU6ShfR 5tnLoZx1UH16k5vDajE3VEAp6GVm+E429YwWXwTdHPgWJNkiTb2rsmN6YZo/7FoKqUl+ke uRf3+jvHUsnf46znYPLiJLDUgF2KVIYCQa63gLNnnpLQ1+Uiz0OUNLz/GuPxjA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681132124; a=rsa-sha256; cv=none; b=h6KMNdi7bbXuy+RZlM4U/DQ+g0AMaH0bGags5eotjARM8rKtZ5sRRQXf5xZZYg9oll7yyF EpjTA3QsBW5M2FoIi0/+oFxkDAkd+gP+y18qx0foq0VSBaVyY20S+tBwjNHTD6++khNc90 a9VmHo7vSSr00a05PmRAUgPPzsjH6xt3LZUqWIMAbaYAhCD6JO3/OUafiUKqoTxTWAa9Q4 tK/hLIJTnxBZFZPpBDIPxe/m8TF2NY4dNyqzlgSQJ7CKoF6kieCf0GjpHYrNXZuf+5Pny4 28zDBTadv6WZ/W61tmUotL2o7q5FKVD2cK2FfqTsxHjQy4MBEtEUcT7/cbl2kQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 9E9E76929; Mon, 10 Apr 2023 13:08:44 +0000 (UTC) Date: Mon, 10 Apr 2023 13:08:44 +0000 From: Alexey Dokuchaev To: Yuri Cc: Mateusz Guzik , Poul-Henning Kamp , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 643336549081 - main - If copy_file_range(2) fails with EXDEV, use fall-back. Message-ID: References: <202304040740.3347eiU8033699@gitrepo.freebsd.org> <202304040959.3349xqqB005509@critter.freebsd.dk> <202304041015.334AF7oF006042@critter.freebsd.dk> <872bff80-a306-a5b8-dbc1-cf54be85fa81@aetern.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ThisMailContainsUnwantedMimeParts: N On Tue, Apr 04, 2023 at 11:31:49AM +0000, Alexey Dokuchaev wrote: > On Tue, Apr 04, 2023 at 12:31:53PM +0200, Yuri wrote: > > Mateusz Guzik wrote: > > > On 4/4/23, Poul-Henning Kamp wrote: > > >> -------- > > >> Alexey Dokuchaev writes: > > >> > > >>> Okay, but did it leave an empty file, I wonder? > > >> > > >> I didn't check, but it probably would, because cp(1) must have opened > > >> and created the destination in order to call copy_file_range(2). > > >> > > >> PS: I'll note that EXDEV is not a documented return value from > > >> copy_file_range(2), and my surprise that cp(1) did not revert > > >> to the fall-back, no matter why copy_file_range(2) failed. > > > > > > that's a new one and should not be happening, something is borked in > > > the kernel -- cross device copies *are* supported > > > > > > i'll look into it later > > > > Likely has to do with openzfs merge issues reported by Cy just above? > > If cp(1) producing empty files for me after commit c98a764c681f is also > EXDEV-related (which I'm not sure as of yet), it could be that recent > OpenZFS merely exposed an earlier bug (c98a764c681f is from Jan 2 2021). > And I didn't have any ZFS on that machine. Never mind, I've eventually figured it out, it's a totally different bug, having nothing to do with OpenZFS or EXDEV. ./danfe