From owner-svn-src-all@FreeBSD.ORG  Mon Aug  3 18:46:25 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D3AAA1065672;
	Mon,  3 Aug 2009 18:46:25 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id AA9EB8FC13;
	Mon,  3 Aug 2009 18:46:25 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [65.122.17.41])
	by cyrus.watson.org (Postfix) with ESMTPS id 6289246B0C;
	Mon,  3 Aug 2009 14:46:25 -0400 (EDT)
Date: Mon, 3 Aug 2009 19:46:25 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Hans Petter Selasky <hselasky@c2i.net>
In-Reply-To: <200908032033.08169.hselasky@c2i.net>
Message-ID: <alpine.BSF.2.00.0908031945320.11341@fledge.watson.org>
References: <20090802192902.GS47463@elvis.mu.org>
	<20090803.012206.1492586399.imp@bsdimp.com>
	<20090804032402.J21599@delplex.bde.org>
	<200908032033.08169.hselasky@c2i.net>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: src-committers@freebsd.org, Bruce Evans <brde@optusnet.com.au>,
	svn-src-all@freebsd.org, alfred@freebsd.org, nparhar@gmail.com,
	svn-src-head@freebsd.org, "M. Warner Losh" <imp@bsdimp.com>
Subject: Re: svn commit: r195960 - in head/sys/dev/usb: . controller input
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Aug 2009 18:46:26 -0000


On Mon, 3 Aug 2009, Hans Petter Selasky wrote:

> On Monday 03 August 2009 19:46:16 Bruce Evans wrote:
>> On Mon, 3 Aug 2009, M. Warner Losh wrote:
>>> In message: <200908030827.21108.hselasky@c2i.net>
>>>
>>> : I see two solutions:
>>> :
>>> : 1) Disable the timekeeping if no keys are pressed.
>>> :
>>> : 2) Second option is to use getmicrotime. Actually what I need is just a
>>> : millisecond time reference so I know when to repeat the last key.
>>> :
>>> : Any opinions? DELAY() or getmicrotime() ?
>>
>> DELAY(1) is somewhet usable.
>
> I think DELAY(1) is not accurate enough.
>
> I suggest that the DELAY(1000) is only active while a key is actually 
> pressed.
>
> See attached patch. Please test and report back.

This seems a reasonable middle ground -- avoids use of sensitive time counters 
in DDB, avoids expensive poll operation most of the time, and allows key 
repeat to work, which is especially nice for backspace in DDB. :-)

Robert