Date: Thu, 10 Aug 2017 12:45:39 +0000 From: "oleg (Oleg Bulyzhin)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D1777: Associated fix for arp/nd6 timer usage. Message-ID: <bc482650b302d28866c6f6675412a9b1@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-7mg6mtc3edzvrggvnij4-req@FreeBSD.org> References: <differential-rev-PHID-DREV-7mg6mtc3edzvrggvnij4-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
oleg added a comment. Please correct me if i'm wrong but there is ref leakage. In particular: "If the callout was restarted, the pending bit will be back on and" agree. "we just want to bail" no, i would say we should do LLE_REMREF(lle) first, then unlock/return because this one is wrong: "since the callout_reset would return 1 and our reference would have been remove by nd6_llinfo_settimer_locked above since canceled would have been 1." If we got callout_pending() !=0 in callout function it does mean callout_reset failed to stop us and callout_reset return value would be 0. REVISION DETAIL https://reviews.freebsd.org/D1777 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: rrs, kib, jhb, imp, lstewart, gnn, sbruno, bz, adrian, rwatson Cc: oleg, ae, bz, freebsd-net-list, emaste, hiren, julian, hselasky
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bc482650b302d28866c6f6675412a9b1>