From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Sep 26 22:00:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C149DCC for ; Thu, 26 Sep 2013 22:00:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9FF992DD2 for ; Thu, 26 Sep 2013 22:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r8QM00FN055022 for ; Thu, 26 Sep 2013 22:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r8QM00mr055021; Thu, 26 Sep 2013 22:00:00 GMT (envelope-from gnats) Resent-Date: Thu, 26 Sep 2013 22:00:00 GMT Resent-Message-Id: <201309262200.r8QM00mr055021@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jean-Sébastien Pédron Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 290EBC7 for ; Thu, 26 Sep 2013 21:59:51 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 159DD2DCD for ; Thu, 26 Sep 2013 21:59:51 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r8QLxoUJ024441 for ; Thu, 26 Sep 2013 21:59:50 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r8QLxoX2024440; Thu, 26 Sep 2013 21:59:50 GMT (envelope-from nobody) Message-Id: <201309262159.r8QLxoX2024440@oldred.freebsd.org> Date: Thu, 26 Sep 2013 21:59:50 GMT From: Jean-Sébastien Pédron To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/182425: [PATCH] graphics/darktable: Fix build with Clang on FreeBSD 10 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Sep 2013 22:00:00 -0000 >Number: 182425 >Category: ports >Synopsis: [PATCH] graphics/darktable: Fix build with Clang on FreeBSD 10 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Sep 26 22:00:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Jean-Sébastien Pédron >Release: FreeBSD 10.0-ALPHA1 >Organization: >Environment: FreeBSD magellan.dumbbell.fr 10.0-ALPHA1 FreeBSD 10.0-ALPHA1 #0 64ee5df7: Mon Sep 16 20:29:01 CEST 2013 root@magellan.dumbbell.fr:/usr/obj/home/dumbbell/Projects/freebsd/src/GIT/sys/GENERIC amd64 >Description: With Clang and libc++ being the default in HEAD, starting with 1000054, darktable fails to build. First, gcc can't be used anymore, until we find a solution to make it use libc++ instead of libstdc++. Otherwise both libraries are loaded at runtime (libstdc++ is used by libdarktable.so and libc++ is used by dependencies) and darktable crashes. For now, until this is fixed, I think the "GCC" option should not be presented to the user for OSVERSION >= 1000054. Then, to build with Clang, a minor patch is required (attached). This patch is already committed upstream and will make it to 1.3.x. >How-To-Repeat: >Fix: Patch attached with submission follows: --- src/common/imageio_exr.hh +++ src/common/imageio_exr.hh @@ -21,7 +21,11 @@ #include "common/image.h" #include "common/mipmap_cache.h" +#if __cplusplus >= 201103L || defined(__clang__) +#include +#else #include +#endif #include #include @@ -56,7 +60,11 @@ public: } uint32_t size; +#if __cplusplus >= 201103L || defined(__clang__) + std::shared_ptr data; +#else std::tr1::shared_ptr data; +#endif }; >Release-Note: >Audit-Trail: >Unformatted: