From owner-cvs-all@FreeBSD.ORG Thu Jun 3 14:09:56 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C22D16A4CE; Thu, 3 Jun 2004 14:09:56 -0700 (PDT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id DA86343D48; Thu, 3 Jun 2004 14:09:55 -0700 (PDT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id B7138530C; Thu, 3 Jun 2004 23:09:54 +0200 (CEST) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id 7A52E5309; Thu, 3 Jun 2004 23:09:47 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602) id 2EEEA33CAA; Thu, 3 Jun 2004 23:09:47 +0200 (CEST) To: "M. Warner Losh" References: <20040603.091250.82990500.imp@bsdimp.com> <20040603.092954.114645644.imp@bsdimp.com> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Thu, 03 Jun 2004 23:09:47 +0200 In-Reply-To: <20040603.092954.114645644.imp@bsdimp.com> (M. Warner Losh's message of "Thu, 03 Jun 2004 09:29:54 -0600 (MDT)") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.63 cc: mux@FreeBSD.org cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: scottl@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jun 2004 21:09:56 -0000 "M. Warner Losh" writes: > des@des.no (Dag-Erling Sm=F8rgrav) writes: > : "M. Warner Losh" writes: > : > How about an API? How does the driver deal with the global/instance > : > variable split? If I set dev.fxp.gerbil to 1 and dev.fxp.1.gerbil to > : > 23? Is that order dependent? > : that's up to the driver author to decide. > That's why I want to know the API the driver will use so that it can > be judged as sufficient or not. I also think we should have some kind > of default design pattern. The API will be {devclass,device}_get_sysctl_{ctx,tree}(). The driver then adds children to these nodes using sysctl_add_*(). > : you can't have the driver be the parent, because some devices have no > : driver (but they all have a class), and I want to use dev.fxp.fxp0 > : instead of dev.fxp.0 on the off chance that there might be multiple > : devices in a class with the same unit number but different names. > That can't happen. If it does, I want other things to break as well > so we notice when it does. I'd rather see symetry with the hints > mechanism. OK, I'll do dev.fxp.0.foo then. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no