From owner-freebsd-i18n@FreeBSD.ORG Thu Feb 28 07:38:33 2013 Return-Path: Delivered-To: freebsd-i18n@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id B135EEA2 for ; Thu, 28 Feb 2013 07:38:33 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.mypc.hu (server.mypc.hu [87.229.73.95]) by mx1.freebsd.org (Postfix) with ESMTP id 4F416FBF for ; Thu, 28 Feb 2013 07:38:33 +0000 (UTC) Received: from server.mypc.hu (localhost [127.0.0.1]) by server.mypc.hu (Postfix) with ESMTP id 767B314D2512; Thu, 28 Feb 2013 08:38:25 +0100 (CET) X-Virus-Scanned: amavisd-new at !change-mydomain-variable!.example.com Received: from server.mypc.hu ([127.0.0.1]) by server.mypc.hu (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id hl9r0NV3hUSj; Thu, 28 Feb 2013 08:38:14 +0100 (CET) Received: from [152.66.168.85] (dhcp-85.q.wlan.net.bme.hu [152.66.168.85]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by server.mypc.hu (Postfix) with ESMTPSA id 9F1B214D242C; Thu, 28 Feb 2013 08:38:14 +0100 (CET) Message-ID: <512F0964.4090506@FreeBSD.org> Date: Thu, 28 Feb 2013 08:38:12 +0100 From: Gabor Kovesdan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Xin LI Subject: Re: patch for in tree iconv References: <20130227213200.GB55866@funkthat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: John-Mark Gurney , freebsd-i18n@freebsd.org X-BeenThere: freebsd-i18n@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: FreeBSD Internationalization Effort List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2013 07:38:33 -0000 Em 27-02-2013 22:38, Xin LI escreveu: > > > On Wed, Feb 27, 2013 at 1:32 PM, John-Mark Gurney > wrote: > > I've worked at fixing a few of iconv's locking issues, and I've > attached > this patch. This should fix most/all of the locking related issues > relating to the global lock... > Thank you, I have had this on my TODO list for a long time just haven't got time for it! > > > Though I ran the tests in tools/test/iconv, and it looks like the > checked in reference conversion in ref are wrong... The > UTF-32 -> ASCII map (ref/ASCII-rev) has: > 0x00A3 = 0x626C > 0x00A5 = 0x6E6579 > > I'm pretty sure 0x626C and 0x6E6579 are not valid ASCII > characters.. :) > > w/ my updates, they are properly(?) mapped to 0x3F... I'm not sure > what they were w/o my changes... > Seems like a good solution. However, the ref tables were generated with GNU libiconv (since the goal is a good compatibility) so we should also track down why does it emit this. > > > I already committed a fixed for an issue w/ svn keywords in > tablegen/cmp.sh... Hence, why I'm able to run the tests.. > Thanks for doing this! Please also keep me CC'd, I'm not on the list but I'm interested in iconv-related things. Gabor