From owner-svn-src-all@freebsd.org Fri Jan 11 16:48:48 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C12C41495713; Fri, 11 Jan 2019 16:48:48 +0000 (UTC) (envelope-from lars@e.0x20.net) Received: from mail.0x20.net (mail.0x20.net [46.251.251.56]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "0x20.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BE3A73820; Fri, 11 Jan 2019 16:48:47 +0000 (UTC) (envelope-from lars@e.0x20.net) Received: from e.0x20.net (mail.0x20.net [46.251.251.56]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.0x20.net (Postfix) with ESMTPS id 8F904C3549; Fri, 11 Jan 2019 17:47:54 +0100 (CET) Received: (from lars@localhost) by e.0x20.net (8.15.2/8.15.2/Submit) id x0BGlstf058579; Fri, 11 Jan 2019 17:47:54 +0100 (CET) (envelope-from lars) Date: Fri, 11 Jan 2019 17:47:54 +0100 From: Lars Engels To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r342945 - in head: tools/build/mk usr.sbin/bluetooth usr.sbin/bluetooth/bluetooth-config Message-ID: <20190111164754.GB1267@e.0x20.net> References: <201901111552.x0BFqAxa049564@repo.freebsd.org> <201901111604.x0BG4XoU021904@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <201901111604.x0BG4XoU021904@pdx.rh.CN85.dnsmgr.net> X-Editor: VIM - Vi IMproved 8.0 User-Agent: Mutt/1.11.1 (2018-12-01) X-Rspamd-Queue-Id: 4BE3A73820 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.94)[-0.940,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 16:48:49 -0000 On Fri, Jan 11, 2019 at 08:04:33AM -0800, Rodney W. Grimes wrote: > > Author: lme (ports committer) > > Date: Fri Jan 11 15:52:09 2019 > > New Revision: 342945 > > URL: https://svnweb.freebsd.org/changeset/base/342945 > > +.Nm > > +utility first appeared in > > +.Fx 12.1 . > > +.Sh AUTHORS > > +.An Dirk Engling Aq Mt erdgeist@erdgeist.org > > +.Sh THANKS TO > > +Lars Engels and Warren Block for suggestions, help, and testing. > > The contents of this file appear twice???? Yes, sorry. My fault. Bapt already fixed this in r342947. > > > > Added: head/usr.sbin/bluetooth/bluetooth-config/bluetooth-config.sh > > ============================================================================== > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/usr.sbin/bluetooth/bluetooth-config/bluetooth-config.sh Fri Jan 11 15:52:09 2019 (r342945) > > @@ -0,0 +1,275 @@ > > +#!/bin/sh > > +#- > > +# Copyleft 2019 Dirk Engling > > That implies the GPL, would you be willing to change it to > what it appears your actually asserting, a Copyright, please. I just asked Dirk if I can change this to "Copyright". It was a mistake on his side and he agrees to the change. > > > +# > > +# This script is released under the beerware license. > > Incomplete and none deterministic license reference, > this needs to be corrected in some way, preferable > with the text of the beerware license so there is > no doubt as to what applies. I'll add the Beerware header. > > +# After function definitions, main() can use them > > +main "$@" > > + > > +exit > > + > > +# TODO > > +# * If device is a keyboard, offer a text entry test field and if it does > > +# not succeed, leave some clues for debugging (i.e. if the node responds > > +# to pings, maybe switch keyboard on/off, etc) > > +# * Same if device is a mouse, i.e. hexdump /dev/sysmouse. > > +# * If device offers DUN profiles, ask the user if an entry in > > +# /etc/ppp/ppp.conf should be created > > +# * If OPUSH or SPP is offered, refer to the respective man pages to give > > +# some clues how to continue > > > > > > The style of this .sh does not match the normal style of > such things in base, especially with respect to long lines > and indentation. Do we have a style guide for shell scripts in base? How should indentation look like? Lars