From owner-freebsd-bugs  Tue Apr 15 02:23:04 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id CAA28559
          for bugs-outgoing; Tue, 15 Apr 1997 02:23:04 -0700 (PDT)
Received: from helios.dnttm.ru (dnttm.wave.ras.ru [194.85.104.197])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id CAA28549
          for <freebsd-bugs@freebsd.org>; Tue, 15 Apr 1997 02:22:53 -0700 (PDT)
Received: (from uutejb@localhost)
	by helios.dnttm.ru (8.8.5/8.8.5/IP-2) with UUCP id NAA05795;
	Tue, 15 Apr 1997 13:02:58 +0400
Received: from localhost (dima@localhost)
	by tejblum.dnttm.rssi.ru (8.8.5/8.8.5) with SMTP id NAA00694;
	Tue, 15 Apr 1997 13:03:53 +0400 (MSD)
Date: Tue, 15 Apr 1997 13:03:53 +0400 (MSD)
From: Dmitrij Tejblum <dima@tejblum.dnttm.rssi.ru>
Reply-To: Dmitrij Tejblum <dima@tejblum.dnttm.rssi.ru>
To: Bruce Evans <bde@zeta.org.au>
cc: peter@spinner.DIALix.COM, phk@dk.tfs.com, freebsd-bugs@freebsd.org,
        tejblum@arc.hq.cti.ru
Subject: Re: misc/3291: md2.h, md4.h, and md5.h headers useless for c++ programms
In-Reply-To: <199704150734.RAA17735@godzilla.zeta.org.au>
Message-ID: <Pine.BSF.3.95q.970415121859.579A-100000@tejblum.dnttm.rssi.ru>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-bugs@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk


On Tue, 15 Apr 1997, Bruce Evans wrote:

> ....
> md4.h now depends on <sys/types.h> for the definition of u32_t.
> This was broken when 64-bit support was fixed (md4.h previously used
> `unsigned long').  This shouldn't be fixed by including <sys/types.h>,
> since <sys/types.h> pollutes the namespace with select and ntoh macros
> and POSIX typedefs.
> 
> md5.h includes <sys/md5.h> which has the same problem as md4.h and uglier
> ifdefs.

And what, you suggest that applications will use own typedef for
u_int32_t before including <md4.h>? If application itself will use
#include <sys/types.h> to obtain the definition, it will get the namespace
pollution.

Why force application to include <sys/types.h> before <md5.h>? Other
md5.h, for example the one from apache (altough it's "broken" too), don't
require it.

May be, include <machine/types.h> in <md4.h> and <sys/md5.h> for
u_int32_t?

	Dima