From owner-freebsd-qa@FreeBSD.ORG  Thu Mar  4 07:45:58 2004
Return-Path: <owner-freebsd-qa@FreeBSD.ORG>
Delivered-To: freebsd-qa@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 61EF716A4CF
	for <freebsd-qa@FreeBSD.org>; Thu,  4 Mar 2004 07:45:58 -0800 (PST)
Received: from gandalf.online.bg (gandalf.online.bg [217.75.128.9])
	by mx1.FreeBSD.org (Postfix) with SMTP id B498E43D41
	for <freebsd-qa@FreeBSD.org>; Thu,  4 Mar 2004 07:45:56 -0800 (PST)
	(envelope-from roam@ringlet.net)
Received: (qmail 26946 invoked from network); 4 Mar 2004 15:43:17 -0000
Received: from office.sbnd.net (HELO straylight.m.ringlet.net)
	(217.75.140.130)
	by gandalf.online.bg with SMTP; 4 Mar 2004 15:43:17 -0000
Received: (qmail 89337 invoked by uid 1000); 4 Mar 2004 15:46:22 -0000
Date: Thu, 4 Mar 2004 17:46:21 +0200
From: Peter Pentchev <roam@ringlet.net>
To: cyrille.lefevre@laposte.net
Message-ID: <20040304154621.GA747@straylight.m.ringlet.net>
Mail-Followup-To: cyrille.lefevre@laposte.net,
	bug-followup@FreeBSD.org, freebsd-qa@FreeBSD.org
References: <20040304152809.GA66105@gits.dyndns.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="9amGYk9869ThD9tj"
Content-Disposition: inline
In-Reply-To: <20040304152809.GA66105@gits.dyndns.org>
User-Agent: Mutt/1.5.6i
cc: bug-followup@FreeBSD.org
cc: freebsd-qa@FreeBSD.org
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation
	time
X-BeenThere: freebsd-qa@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: FreeBSD Quality Assurance <freebsd-qa.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-qa>,
	<mailto:freebsd-qa-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-qa>
List-Post: <mailto:freebsd-qa@freebsd.org>
List-Help: <mailto:freebsd-qa-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-qa>,
	<mailto:freebsd-qa-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Mar 2004 15:45:58 -0000


--9amGYk9869ThD9tj
Content-Type: text/plain; charset=windows-1251
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 04, 2004 at 04:28:09PM +0100, Cyrille Lefevre wrote:
> cvs diff against -current (FreeBSD 5.2-CURRENT #1: Sat Jan 31 15:17:05 CE=
T 2004)
> anyone to commit this PR ?
> thanks in advance.
> =20
[snip]
>      /* Begin user dialog at outer menu */
>      dialog_clear();
> +    if (getpid() =3D=3D 1)
> +        dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max, FAL=
SE);
>      while (1) {

Just a minor comment: shouldn't RunningAsInit be used here instead of
a getpid() invocation? :)

G'luck,
Peter

--=20
Peter Pentchev	roam@ringlet.net    roam@sbnd.net    roam@FreeBSD.org
PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
This sentence contains exactly threee erors.

--9amGYk9869ThD9tj
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAR09N7Ri2jRYZRVMRAlqKAKCTcAmVGc3Rc6afzhZmrg/Go4Y8OQCeN/ap
Rfl6hZllFD+ZxsXqxlOhHFk=
=qPre
-----END PGP SIGNATURE-----

--9amGYk9869ThD9tj--