Date: Sat, 28 Sep 2002 19:57:30 -0400 (EDT) From: Alan Eldridge <ports@geeksrus.net> To: FreeBSD-gnats-submit@FreeBSD.org Cc: skv@FreeBSD.org, portmgr@FreeBSD.org Subject: ports/43460: textproc/p5-PodParser: should not depend on File::Spec for Perl 5.8 Message-ID: <200209282357.g8SNvU0c049478@wwweasel.geeksrus.net>
next in thread | raw e-mail | index | archive | help
>Number: 43460
>Category: ports
>Synopsis: textproc/p5-PodParser: should not depend on File::Spec for Perl 5.8
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Sep 28 17:00:15 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: Alan Eldridge
>Release: FreeBSD 4.7-RC i386
>Organization:
Geeksrus.NET
>Environment:
System: FreeBSD wwweasel.geeksrus.net 4.7-RC FreeBSD 4.7-RC #1: Wed Sep 25 02:04:21 EDT 2002 root@wwweasel.geeksrus.net:/usr/obj/usr/src/sys/WWWEASEL i386
>Description:
Perl 5.8.0 contains a newer version of File::Spec than the port.
Request permission to commit now.
>How-To-Repeat:
>Fix:
Yes, that weird command works. I had to think of some way to get a
comparable integer out of the various PERL_VER values we could have
to deal with (5.005 really throws a spanner in the works).
I'd like to do that entirely with Make substitutions, but I don't think
I can without some serious cogitation, convening with the undead, and the
occasional goat or 1337 14m3R sacrifice.. oh, and I might need one of
Netwizard's dead sheep, too. (Look, *he's* the one's been killing sheep,
*not* me....)
Once I figger out a better way to do it I'll put it in bsd.port.mk. It's
kinda surprising we don't have a comparable version value in there now.
==8<====8<====8<====8<====8<====8<====8<====8<====8<====8<==
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/textproc/p5-PodParser/Makefile,v
retrieving revision 1.3
diff -u -3 -r1.3 Makefile
--- Makefile 12 Sep 2002 17:22:03 -0000 1.3
+++ Makefile 28 Sep 2002 08:57:33 -0000
@@ -14,9 +14,6 @@
MAINTAINER= skv@FreeBSD.org
-BUILD_DEPENDS= ${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/File/Spec.pm:${PORTSDIR}/devel/p5-File-Spec
-RUN_DEPENDS= ${BUILD_DEPENDS}
-
PERL_CONFIGURE= yes
MAN1= pod2usage.1 podchecker.1 podselect.1
@@ -29,4 +26,13 @@
post-patch:
@${FIND} ${WRKSRC} -name \*.orig -exec ${RM} {} \;
-.include <bsd.port.mk>
+.include <bsd.port.pre.mk>
+
+PV!= echo ${PERL_VER} 0 0 | sed -e 's|\.| |g' -e 's| 0*\([1-9]\)| \1|g' \
+ | xargs printf '%d%003d%003d\t' | cut -f1
+.if ${PV} < 5008000
+BUILD_DEPENDS= ${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/File/Spec.pm:${PORTSDIR}/devel/p5-File-Spec
+RUN_DEPENDS= ${BUILD_DEPENDS}
+.endif
+
+.include <bsd.port.post.mk>
==8<====8<====8<====8<====8<====8<====8<====8<====8<====8<==
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200209282357.g8SNvU0c049478>