From owner-dev-commits-src-all@freebsd.org Sun Aug 8 07:16:03 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 70D4D650E10 for ; Sun, 8 Aug 2021 07:16:03 +0000 (UTC) (envelope-from mw@semihalf.com) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Gj9VV4jLQz3mnL for ; Sun, 8 Aug 2021 07:16:02 +0000 (UTC) (envelope-from mw@semihalf.com) Received: by mail-qt1-x82f.google.com with SMTP id l24so9992864qtj.4 for ; Sun, 08 Aug 2021 00:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AxHM7cCD94wFdDWu1/8FZcGPJG1u8O4WZCY3kHek8fM=; b=lLfl96RGjKaPd1CIlJsl8/j0xfCcPFi4tVyeq7GevCpAC9AJ0KS5VTZEwP5QYd8p81 8Pch38PrMr2IAuM+Gpws/KOSH7K7j1SPDxv7Zg8s/HAgMLuKP7acKQVIGk6RI6QqEzaD pvVTivYVnTUtc0CrU3i/XqBlpTi8wkKh4zzuIKvHYHYQUUqPgscZG6b2sVbEZhPSSuOi fz6oyQFm9VA8J/xrRVIEjzWUKnLJLoi8Dpc7t7QabYjtjFHYAfDWLf4wNMoON4EVrJOy uwtciTDWpum8NVBdAjn7oJookujyd86iI/jaTK17AHagYzZ1eCQGqBhukB/+Sv1uJTOI tpsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AxHM7cCD94wFdDWu1/8FZcGPJG1u8O4WZCY3kHek8fM=; b=h23zxbZVUKQkUIC1ww7mYh30o/Dr+5EtowdgVDkh3cAaHyVX4tbthCzEJsEtslDr67 NSeRuyFfQe+0yUhItyhStWg7uEE9LZOC1QszDmKM0RkIQcAzOOjEmJuZ1uImF8f6t7PL ei22iMPnFoeUNbLfpV3qUGkXBv9/YpJnDbIqnwsx0NtIQG2Ivq+WPW/JCrlbmz0avKhz StYyIVaBoZ14T/PYohcqX3hF1F+p2KEUfuxW0/AcoBkjt5Lcb8NfrZkv0MaBR+QcN+a9 2YsB4PfvMIGlQ8hngj6DRS9al/pC6ulFSUgiWUdXQPGHaW/WCU8LoJj4XlnLwk5TYN6e D5rQ== X-Gm-Message-State: AOAM53026y2mfE7NwLkBWZdt2zKGp7E4IAx5Rudk5xI5wNFglTh7W8gA 4RO0Nwh+nwX/aZi6jGl+62bH+qj1Mq3cO6qfR3j2fA== X-Google-Smtp-Source: ABdhPJw4B0uix3gReVFRmrs8pirsQkjiJIG/qTkXlpjgXtvcGpPQNBcl8aasRQ4345V0AmI2KtwZjWb/P7wlhG36QAc= X-Received: by 2002:ac8:44c2:: with SMTP id b2mr14897748qto.216.1628406962111; Sun, 08 Aug 2021 00:16:02 -0700 (PDT) MIME-Version: 1.0 References: <202108031008.173A84BG096694@gitrepo.freebsd.org> In-Reply-To: From: Marcin Wojtas Date: Sun, 8 Aug 2021 09:15:52 +0200 Message-ID: Subject: Re: git: dfcaa2c18bf9 - main - enetc_mdio: Support building the driver as a loadable module. To: Ian Lepore Cc: Marcin Wojtas , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4Gj9VV4jLQz3mnL X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=lLfl96RG; dmarc=none; spf=none (mx1.freebsd.org: domain of mw@semihalf.com has no SPF policy when checking 2607:f8b0:4864:20::82f) smtp.mailfrom=mw@semihalf.com X-Spamd-Result: default: False [-3.30 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[semihalf-com.20150623.gappssmtp.com:s=20150623]; FREEFALL_USER(0.00)[mw]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; DMARC_NA(0.00)[semihalf.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[semihalf-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::82f:from]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-src-all] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Aug 2021 07:16:03 -0000 Hi Ian, wt., 3 sie 2021 o 18:31 Ian Lepore napisa=C5=82(a): > > On Tue, 2021-08-03 at 10:08 +0000, Marcin Wojtas wrote: > > The branch main has been updated by mw: > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=3Ddfcaa2c18bf9c69b94d531364f891= 3b23f19505f > > > > commit dfcaa2c18bf9c69b94d531364f8913b23f19505f > > Author: Kornel Duleba > > AuthorDate: 2021-07-28 11:38:53 +0000 > > Commit: Marcin Wojtas > > CommitDate: 2021-08-03 10:07:49 +0000 > > > > enetc_mdio: Support building the driver as a loadable module. > > > > [...] > > diff --git a/sys/modules/enetc_mdio/Makefile > > b/sys/modules/enetc_mdio/Makefile > > new file mode 100644 > > index 000000000000..f448fc526705 > > --- /dev/null > > +++ b/sys/modules/enetc_mdio/Makefile > > @@ -0,0 +1,8 @@ > > +#$FreeBSD$ > > + > > +.PATH: ${SRCTOP}/sys/dev/enetc > > + > > +KMOD =3D enetc_mdio > > +SRCS =3D enetc_mdio_pci.c enetc_mdio.c > > + > > +.include > > A module makefile must list all the header files it uses which are > generated at build time from interface definitions (.m files) in its > SRCS list. For this driver, I think that means ifdi_if.h and > miibus_if.h. > > -- Ian > Agreed. Part of it was already fixed by manu, I'm about to add remaining dependencies. Thanks, Marcin