From owner-svn-ports-head@freebsd.org  Thu Oct 19 17:18:28 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 626A8E41357;
 Thu, 19 Oct 2017 17:18:28 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4360D71B96;
 Thu, 19 Oct 2017 17:18:28 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 8C07A1642A; Thu, 19 Oct 2017 17:18:27 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Steve Wills <swills@FreeBSD.org>
Cc: Shane <FreeBSD@ShaneWare.Biz>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r452416 - in head/graphics/opensubdiv: . files
References: <201710191219.v9JCJbHV026836@repo.freebsd.org>
Date: Thu, 19 Oct 2017 19:18:21 +0200
In-Reply-To: <201710191219.v9JCJbHV026836@repo.freebsd.org> (Steve Wills's
 message of "Thu, 19 Oct 2017 12:19:37 +0000 (UTC)")
Message-ID: <1slz-gioy-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Oct 2017 17:18:28 -0000

Steve Wills <swills@FreeBSD.org> writes:

> -COMMENT=	High performance subdivision surface libraries
> +COMMENT=	OpenSubdiv graphics library

why the regression? "graphics" is also the default theme for anything
under graphics/ category.

> 2. Do not include the package name or version number of software.

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-comment.html

> -DISTVERSIONPREFIX=	v
> -DISTVERSION=	3_0_5
> +PORTVERSION=	3.3.0
[...]
> +GH_TAGNAME=	v3_3_0

Why the regression?

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex3

> CMAKE_VERBOSE=	yes

Does nothing after r421635.

> +DOCS_CMAKE_ON=	-DNO_DOC:BOOL=OFF
> +DOCS_CMAKE_OFF=	-DNO_DOC:BOOL=ON
[...]
> +EXAMPLES_CMAKE_ON=	-DNO_EXAMPLES:BOOL=OFF
> +EXAMPLES_CMAKE_OFF=	-DNO_EXAMPLES:BOOL=ON
[...]
> +OPENCL_CMAKE_ON=	-DNO_OPENCL:BOOL=OFF
> +OPENCL_CMAKE_OFF=	-DNO_OPENCL:BOOL=ON
[...]
> +PTEX_CMAKE_ON=	-DNO_PTEX:BOOL=OFF ...
> +PTEX_CMAKE_OFF=	-DNO_PTEX:BOOL=ON
[...]
> +TBB_CMAKE_ON=	-DNO_TBB:BOOL=OFF
> +TBB_CMAKE_OFF=	-DNO_TBB:BOOL=ON
[...]
> +TEST_CMAKE_ON=	-DNO_REGRESSION:BOOL=OFF -DNO_TESTS:BOOL=OFF -DNO_GLTESTS:BOOL=OFF
> +TEST_CMAKE_OFF=	-DNO_REGRESSION:BOOL=ON -DNO_TESTS:BOOL=ON -DNO_GLTESTS:BOOL=ON
[...]
> +TUTORIALS_CMAKE_ON=	-DNO_TUTORIALS:BOOL=OFF
> +TUTORIALS_CMAKE_OFF=	-DNO_TUTORIALS:BOOL=ON

Did you know _CMAKE_BOOL_OFF helper was added a year ago to simplify such cases?

> +OPENCL_CFLAGS=	-pthread
> +OPENCL_CXXFLAGS=	-pthread

CFLAGS is appended to CXXFLAGS *by default*.

> +post-patch:
> +	${FIND} ${WRKSRC}/tutorials -name CMakeLists.txt | ${XARGS} ${REINPLACE_CMD} \
> +	-e 's|{CMAKE_BINDIR_BASE}/tutorials|{CMAKE_INSTALL_PREFIX}/share/${PORTNAME}/tutorials|g'

share/${PORTNAME} is ${DATADIR_REL}

> +	${FIND} ${WRKSRC}/examples -name CMakeLists.txt | ${XARGS} ${REINPLACE_CMD} \
> +	-e 's|{CMAKE_BINDIR_BASE}|{CMAKE_INSTALL_PREFIX}/share/${PORTNAME}/examples|g'

share/${PORTNAME}/examples should probably be ${EXAMPLESDIR_REL}

> +	${FIND} ${WRKSRC}/regression -name CMakeLists.txt | ${XARGS} ${REINPLACE_CMD} \
> +	-e 's|{CMAKE_BINDIR_BASE}|{CMAKE_INSTALL_PREFIX}/share/${PORTNAME}/test|g'

According to hier(7) and devel/kyua tests should probably go under tests/${PORTNAME}.

Why use xargs(1) for a feature built into find(1)?

     -exec utility [argument ...] {} +
             Same as -exec, except that "{}" is replaced with as many
             pathnames as possible for each invocation of utility.  This
             behaviour is similar to that of xargs(1).  The primary always
             returns true; if at least one invocation of utility returns a
             non-zero exit status, find will return a non-zero exit status.