From nobody Sun Mar 15 20:18:32 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fYqL61pN3z6VMhV for ; Sun, 15 Mar 2026 20:18:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fYqL56Mk5z3tYJ for ; Sun, 15 Mar 2026 20:18:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773605917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UdnCzw5XYSjD3P9HNiZKIj9YcF8pGn9PLKazM5UludI=; b=DmtKbTej0LoVF9HKCTL1vCD5zXFj1YKSSqABNrsccXoK7rpmwfBdoYnHgRglf28VkZSw9k OlvFQ1NhH6xrfJ264cpIg6wyxcZRgoM2gwDwAOvtV5wiOTtAQu4mRTUZdFdb/bgT6vkfj2 frVoDGb9U+nYyP/Yf1puQHmpP8kLDw7GvV6Rt6JI8KaTTLrtJ7EFuAorL5bCnUEhSty6dj Xa+lYE9+idlE5HkSpEi+cegjT55FFioDE7/IMqpjO/hn48WotwxyQaUWfjjN+ClxhNsnFB ZXAo6LO+o0z/jdFokSMbVehTje1lgOw/Ut2FF14aO8qLrf3c4K0YXULLD+WWCg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1773605917; a=rsa-sha256; cv=none; b=Fxz7UqauDgO18e34VtqTeEPDOh7PZDU7Mf7/7C1TB9tC9psEebp6bTPxiUn+Ve7t1Zkm8p 5GHuPGoMb73Orf6j0zuM+8k+DycxZ6voNDfPXZQQd7qPLrhOSa5ZP5zbrYjGGXuDi2ArdE oCcaPzwrUAeHqc1PLIgvmpXMCBvFf9aBfAF2NW8skF4lRt5fALIiaE7HyieMEHjNcuZNXS sfD9P57ul8ZpsYe/RE8AZbtLzhKtefcjAC8LkvT831mQ2mQ1neS/Z4mnN2VaB6e8WnZlmh 1ied86ZJX1q75uiJLvvfRmMzRaL1DKuXyGkVLi9FVS+Y8mZPv54oqyEuN+dfSA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773605917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UdnCzw5XYSjD3P9HNiZKIj9YcF8pGn9PLKazM5UludI=; b=Kuek3bGzO1jXfINRS6NmIiUN2OTvXY+TlVLZeMASg7qQa7oYMc0l7P/6oO0MFfOCYf3ytI 8vywiqC4Itng28eCH6O/2sJ9O9tfxXRK7WmM7d9pcyZld+wQOE1w1TUsNMWNrH7NLWd5MA UVET2Yutum/zlzf787pxJaw983TpdjrlU1yBPranCkO8AE73i9SSI4Jk5HXMBpo9RFsby3 W/OB3engjBoqgDQjCLcW3m949Ukin09LASnT9DRnr2OSPybDnUXXhoSvcHP08ipmrvw26M TCFYHYNWEVNXR2mglknlw4GTFQQuQMq5oUYXrVJf9Y9/vztgbsTAtSfCg1naXQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fYqL55FNJz13yZ for ; Sun, 15 Mar 2026 20:18:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ca6d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 15 Mar 2026 20:18:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Christos Longros From: Adrian Chadd Subject: git: 9976cff55e88 - main - rge: use C style comments instead of C++ List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9976cff55e8897f74d970567e61512103216cf58 Auto-Submitted: auto-generated Date: Sun, 15 Mar 2026 20:18:32 +0000 Message-Id: <69b71418.3ca6d.3f0c6d22@gitrepo.freebsd.org> The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=9976cff55e8897f74d970567e61512103216cf58 commit 9976cff55e8897f74d970567e61512103216cf58 Author: Christos Longros AuthorDate: 2026-03-15 20:09:56 +0000 Commit: Adrian Chadd CommitDate: 2026-03-15 20:10:59 +0000 rge: use C style comments instead of C++ FreeBSD style(9) mandates C style comments. The initial import from OpenBSD left several C++ style // comments in if_rge.c and if_rgevar.h. Replace them with proper /* */ comments. Also fix a malformed comment that mixed // with a closing */. Signed-off-by: Christos Longros Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D55743 --- sys/dev/rge/if_rge.c | 4 ++-- sys/dev/rge/if_rgevar.h | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/sys/dev/rge/if_rge.c b/sys/dev/rge/if_rge.c index b2f1311b4c87..e5297edfefbe 100644 --- a/sys/dev/rge/if_rge.c +++ b/sys/dev/rge/if_rge.c @@ -1125,7 +1125,7 @@ rge_init_locked(struct rge_softc *sc) * causing this to be initialised both from the ioctl * API and if_init() API. */ -// RGE_PRINT_ERROR(sc, "%s: called whilst running?\n", __func__); +/* RGE_PRINT_ERROR(sc, "%s: called whilst running?\n", __func__); */ return; } @@ -2409,7 +2409,7 @@ rge_hash_maddr(void *arg, struct sockaddr_dl *sdl, u_int cnt) { uint32_t crc, *hashes = arg; - // XXX TODO: validate this does addrlo? */ + /* XXX TODO: validate this does addrlo? */ crc = ether_crc32_be(LLADDR(sdl), ETHER_ADDR_LEN) >> 26; crc &= 0x3f; diff --git a/sys/dev/rge/if_rgevar.h b/sys/dev/rge/if_rgevar.h index 924133da45e3..6228f9ff229e 100644 --- a/sys/dev/rge/if_rgevar.h +++ b/sys/dev/rge/if_rgevar.h @@ -123,7 +123,6 @@ struct rge_rx { int rge_rxq_prodidx; int rge_rxq_considx; -// struct if_rxring rge_rx_ring; bus_addr_t rge_rx_list_paddr; bus_dmamap_t rge_rx_list_map; struct rge_rx_desc *rge_rx_list; @@ -137,7 +136,6 @@ struct rge_queues { void *q_ihc; int q_index; char q_name[16]; -// pci_intr_handle_t q_ih; struct rge_tx q_tx; struct rge_rx q_rx; }; @@ -171,8 +169,6 @@ struct rge_softc { bus_dma_tag_t sc_dmat_rx_buf; bus_dma_tag_t sc_dmat_stats_buf; -// pci_chipset_tag_t sc_pc; -// pcitag_t sc_tag; struct ifmedia sc_media; /* media info */ enum rge_mac_type rge_type;