Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 29 Jul 2017 13:20:21 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 219687] [NEW PORT] net/google-compute-engine: User daemon for Google Compute Engine
Message-ID:  <bug-219687-13-X0xjxcqCVO@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-219687-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-219687-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219687

--- Comment #31 from Po-Chuan Hsieh <sunpoet@FreeBSD.org> ---
(In reply to Helen Koike from comment #28)

1. Either remove PKGNAMEPREFIX=3D${PYTHON_PKGNAMEPREFIX} or change this por=
t as
net/py-google-compute-engine.

We add py- to the directory name and pyXX- to package name for Python
libraries/modules.
Please consider if this port is more of a library or an application.

2. We have ntpdate in base system (/usr/sbin/ntpdate). Is there any reason =
to
use the one from ports?

3. There is compilation error with Python 3. Please add a patch for it.

byte-compiling
/usr/ports/works/usr/ports/net/google-compute-engine/work/stage/usr/local/l=
ib/python3.6/site-packages/google_compute_engine/network_utils.py
to network_utils.cpython-36.pyc
  File
"/usr/local/lib/python3.6/site-packages/google_compute_engine/network_utils=
.py",
line 47
    except Exception, e:
                    ^
SyntaxError: invalid syntax

4. Please sort RUN_DEPENDS and USE_PYTHON.

5. Use REINPLACE_ARGS=3D-i '' to avoid saving backup files.

"@${REINPLACE_CMD} -i -e" in post-patch: will save backup files with "-e"
suffix.

% ls -l google_compute_engine/network_setup/network_setup.py*
-rwxr-xr-x  1 sunpoet  wheel  6454 Jul 29 20:52
google_compute_engine/network_setup/network_setup.py
-rwxr-xr-x  1 sunpoet  wheel  6454 Jul 19 00:49
google_compute_engine/network_setup/network_setup.py-e

It should be "REINPLACE_ARGS=3D-i ''" to avoid saving backup files.

% grep REINPLACE_ARGS /usr/ports/Mk/bsd.port.mk
REINPLACE_ARGS?=3D        -i.bak
REINPLACE_CMD?=3D ${SED} ${REINPLACE_ARGS}

Thanks.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-219687-13-X0xjxcqCVO>