From owner-cvs-all@FreeBSD.ORG Sun Nov 14 16:02:46 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 63E5D16A4CE; Sun, 14 Nov 2004 16:02:46 +0000 (GMT) Received: from web.portaone.com (web.portaone.com [195.70.151.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id BAF4343D46; Sun, 14 Nov 2004 16:02:45 +0000 (GMT) (envelope-from sobomax@portaone.com) Received: from [192.168.1.100] (xDSL-2-2.united.net.ua [193.111.9.226]) (authenticated bits=0) by web.portaone.com (8.12.11/8.12.11) with ESMTP id iAEG2d5w039003 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 14 Nov 2004 17:02:42 +0100 (CET) (envelope-from sobomax@portaone.com) Message-ID: <41978198.5060303@portaone.com> Date: Sun, 14 Nov 2004 18:02:32 +0200 From: Maxim Sobolev Organization: Porta Software Ltd User-Agent: Mozilla Thunderbird 0.9 (Windows/20041103) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Poul-Henning Kamp References: <51924.1100447133@critter.freebsd.dk> In-Reply-To: <51924.1100447133@critter.freebsd.dk> Content-Type: text/plain; charset=KOI8-U; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/make job.c job.h main.c make.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Nov 2004 16:02:46 -0000 Poul-Henning Kamp wrote: > In message <41977CCC.8070607@portaone.com>, Maxim Sobolev writes: > > >>Great job! However I wonder if use of pipe(2) would be better way, which >>will not leave any traces behind it in the case when all makes die in a >>way that prevents them from taking clean up actions (e.g. kill -9). > > > That's how gmake does it, and it is no end of trouble because you > have to hope for the file descriptors to survive open through shell > scripts and other gunk. And passing the numeric filedescriptors > in an environment variable is wrong in all ways it possibly can be. I see. It does not leave much options indeed. -Maxim