From owner-svn-src-head@freebsd.org  Sun Mar 12 11:26:35 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A2F9CF94B0;
 Sun, 12 Mar 2017 11:26:35 +0000 (UTC) (envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id E7F4C18ED;
 Sun, 12 Mar 2017 11:26:34 +0000 (UTC) (envelope-from des@des.no)
Received: from desk.des.no (smtp.des.no [194.63.250.102])
 by smtp.des.no (Postfix) with ESMTP id 7868D9C89;
 Sun, 12 Mar 2017 11:26:27 +0000 (UTC)
Received: by desk.des.no (Postfix, from userid 1001)
 id 48F477357; Sun, 12 Mar 2017 12:26:27 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: "Ngie Cooper \(yaneurabeya\)" <yaneurabeya@gmail.com>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r308996 - head/lib/libfetch
References: <201611221330.uAMDU7fg052989@repo.freebsd.org>
 <93505FD7-FB42-4BD5-834C-6F73EFD9B1CF@gmail.com>
Date: Sun, 12 Mar 2017 12:26:26 +0100
In-Reply-To: <93505FD7-FB42-4BD5-834C-6F73EFD9B1CF@gmail.com> (Ngie Cooper's
 message of "Sat, 11 Mar 2017 20:46:16 -0800")
Message-ID: <86shmid9ct.fsf@desk.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Mar 2017 11:26:35 -0000

"Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> writes:
> Hi Bjoern,

No, that was my father :)

> 	Shouldn=E2=80=99t this be strrchr instead of strchr since you=E2=80=99re
> scanning for the service from the right side of the host,
> e.g. =E2=80=9Cfoo:service=E2=80=9D or =E2=80=9C[::1]:service=E2=80=9D? Th=
is code would match index 3
> in the first example, but it would match index 2 in the second
> example.

Correct, although it may be slightly more complicated, which is why I
didn't immediately jump on it when bz@ pointed it out.  I'm working on
it right now.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no