Date: Fri, 27 Jan 2006 05:30:08 GMT From: "M. Warner Losh" <imp@bsdimp.com> To: freebsd-usb@FreeBSD.org Subject: Re: usb/92403: uplcom.c needs new entry for 4.00 revision of Prolific chipset Message-ID: <200601270530.k0R5U8RZ084718@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR usb/92403; it has been noted by GNATS.
From: "M. Warner Losh" <imp@bsdimp.com>
To: mg@fork.pl
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: usb/92403: uplcom.c needs new entry for 4.00 revision of
Prolific chipset
Date: Thu, 26 Jan 2006 22:27:53 -0700 (MST)
Does this work for you?
Warner
Index: uplcom.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/usb/uplcom.c,v
retrieving revision 1.30
diff -u -r1.30 uplcom.c
--- uplcom.c 4 Dec 2005 10:06:04 -0000 1.30
+++ uplcom.c 27 Jan 2006 05:27:12 -0000
@@ -224,6 +224,9 @@
uint16_t product;
int32_t release; /* release is a 16bit entity,
* if -1 is specified we "don't care"
+ * This is a floor value. The table
+ * must have newer revs before older
+ * revs (and -1 last).
*/
char chiptype;
} uplcom_products [] = {
@@ -320,7 +323,7 @@
for (i = 0; uplcom_products[i].vendor != 0; i++) {
if (uplcom_products[i].vendor == uaa->vendor &&
uplcom_products[i].product == uaa->product &&
- (uplcom_products[i].release == uaa->release ||
+ (uplcom_products[i].release <= uaa->release ||
uplcom_products[i].release == -1)) {
return (UMATCH_VENDOR_PRODUCT);
}
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200601270530.k0R5U8RZ084718>