From nobody Fri Jun 27 07:42:58 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bT6wf5bgZz60RGt; Fri, 27 Jun 2025 07:42:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bT6wf2Dbkz418V; Fri, 27 Jun 2025 07:42:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751010178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ubXgyYn4bl912n0Hi0hNpL0VpeyDXnpBu5cPfXsPo3Y=; b=rfNc9Pz2q7R5LxMp+JeSFRe9rIPgqy8a1/XJVrCya+mcAS98iZDbnoCX7kF0tszQPFWIyj kuHsNVvnjnb/DRCp/aXKiQ4FRXJXdWh5DYAk8Ci0LaTqqv6HhowqftiRG0eugsH3OVyeBh RW+niQCs/tc0USwrAltcsRJ1GhmGwrUnD0h1O/ldFyOdorXwSbiAFhTbvNpTrfLSeaasE2 SaYwKUVk2E5g4d4MDoIWBSQ5qza/GCTzbE4lJBenFr2W8+NAKfLCmfAO2kgwnIPTxoCtZ3 ydq8GQ61DXzyJAhyKU7qvFqhTId4VdaxhOKFK2wDtN0rHC6KDFnM3QGUPTcUkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751010178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ubXgyYn4bl912n0Hi0hNpL0VpeyDXnpBu5cPfXsPo3Y=; b=nROrzoFFdTTHpzo5HzpFUzjgwCbU3UwtVmhqtWEOxquhXNuUztweSDqsDkf30Ly8dntYr/ FOb9xShI0CVarYaO1Ix4sWJrDjroP+qEAvPK/H2d9VvxDcuMhFxSH/d/gnULnm+Q6Qlu0q M5YpQCf1IqflrBaK4Dyam0c0R9ppAKVXof5n4SI3jUW9ELlxTFo9DNMa+VzoF5X0Lb5lXE f+r3/5cepm9aaROMEbiN7Adg6pigEC32HPLjfZSafWU1sh1YOHewfWXqa72xsQM40TaN+I bh2cHrg0Jvopz9vwlFnPkylS8c0FO8uvF2xRgMgWjxGs43is3BdPpF9up178ng== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751010178; a=rsa-sha256; cv=none; b=ZuJyIEzR6hXpj6BsWc5/rnK0BTkxa9g5ZlFXbhEZHdDmn3C6z/fZlFc+QokLHEvE+zq085 hot6cHHBQTBe4wss0kCMywlk7LstYjvoe7pnsr5Og5qUIk59w5FK1hn9rMElJpJf958f8A /aARALhbh5eDiMo6mZlDNNE5GrG7aKdcIeKhiS2ksRCR7spBAwOn5XvZbUH9a8lwkUztyR M2yY5cFzm8hkP4AjmTUmWH6+E07qH5VqeLBKiy9NLq/txLk/PHrXQejo1ZOMkLHCcjeWW4 kkUerRbtovhBfLy1ZKlVSpfipw0smtm5br7E2336hm2thmz3OHsV1tnW7+cjbw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bT6wf1r8czgSc; Fri, 27 Jun 2025 07:42:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55R7gwUt006829; Fri, 27 Jun 2025 07:42:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55R7gwIS006826; Fri, 27 Jun 2025 07:42:58 GMT (envelope-from git) Date: Fri, 27 Jun 2025 07:42:58 GMT Message-Id: <202506270742.55R7gwIS006826@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Andriy Gapon Subject: git: 4d1ff6d22ba7 - stable/13 - dwc_otg_fdt: do not create and leak extra usbus child List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 4d1ff6d22ba7eb33ebcae15a8c645cae8eea7f56 Auto-Submitted: auto-generated The branch stable/13 has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=4d1ff6d22ba7eb33ebcae15a8c645cae8eea7f56 commit 4d1ff6d22ba7eb33ebcae15a8c645cae8eea7f56 Author: Andriy Gapon AuthorDate: 2025-05-19 09:06:55 +0000 Commit: Andriy Gapon CommitDate: 2025-06-27 07:39:55 +0000 dwc_otg_fdt: do not create and leak extra usbus child dwc_otg_init() already takes care of creating the bus and setting up sc to point to it. Fixes: 518da7ace813e (cherry picked from commit 97c799661a76b78963fd9f92a7e6bb452ebba999) --- sys/dev/usb/controller/dwc_otg_fdt.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/dev/usb/controller/dwc_otg_fdt.c b/sys/dev/usb/controller/dwc_otg_fdt.c index d698ace8e040..e256b60c902b 100644 --- a/sys/dev/usb/controller/dwc_otg_fdt.c +++ b/sys/dev/usb/controller/dwc_otg_fdt.c @@ -141,10 +141,6 @@ dwc_otg_attach(device_t dev) if (sc->sc_otg.sc_irq_res == NULL) goto error; - sc->sc_otg.sc_bus.bdev = device_add_child(dev, "usbus", -1); - if (sc->sc_otg.sc_bus.bdev == NULL) - goto error; - err = dwc_otg_init(&sc->sc_otg); if (err == 0) { err = device_probe_and_attach(sc->sc_otg.sc_bus.bdev);