From owner-cvs-all Fri Jan 10 10:56:19 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 131C937B405; Fri, 10 Jan 2003 10:56:18 -0800 (PST) Received: from out7.mx.nwbl.wi.voyager.net (out7.mx.nwbl.wi.voyager.net [169.207.3.125]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F39243F3F; Fri, 10 Jan 2003 10:56:17 -0800 (PST) (envelope-from silby@silby.com) Received: from [10.1.1.6] (d9.as12.nwbl0.wi.voyager.net [169.207.135.9]) by out7.mx.nwbl.wi.voyager.net (Postfix) with ESMTP id C7B9F92FE4; Fri, 10 Jan 2003 12:56:14 -0600 (CST) Date: Fri, 10 Jan 2003 13:03:39 -0600 (CST) From: Mike Silbersack To: Doug Barton Cc: Maxime Henrion , "" , "" Subject: Re: cvs commit: src/sys/pci if_xl.c if_xlreg.h In-Reply-To: <20030109002237.U90866@2-234-22-23.pyvrag.nggov.pbz> Message-ID: <20030110130229.C14055-200000@patrocles.silby.com> References: <200212170008.gBH08owJ048742@repoman.freebsd.org> <3E1D29ED.8030804@dougbarton.net> <20030109021139.C6353-100000@patrocles.silby.com> <20030109002237.U90866@2-234-22-23.pyvrag.nggov.pbz> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-346410064-1042225419=:14055" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-346410064-1042225419=:14055 Content-Type: TEXT/PLAIN; charset=US-ASCII On Thu, 9 Jan 2003, Doug Barton wrote: > On Thu, 9 Jan 2003, Mike Silbersack wrote: > > > I'd suggest adding some code to doublecheck that the chip actually came > > out of the D3 state before continuing on. The failure you're reporting > > comes too soon and at too low of a level to be due to any of the changes > > Maxime or I have done recently. > > OK... thanks for letting me know. Adding that kind of code is beyond me, > but if someone more knowledgable wants to send me patches, I'll be happy > to give them a try. > > Doug Give this patch a try, see what it says. I added both the check to doublecheck that it came out of powersaving, and a bit of delay to perhaps give it time to do so. Mike "Silby" Silbersack --0-346410064-1042225419=:14055 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="if_xl.c-dougbarton.patch" Content-Transfer-Encoding: BASE64 Content-ID: <20030110130339.S14055@patrocles.silby.com> Content-Description: Content-Disposition: attachment; filename="if_xl.c-dougbarton.patch" LS0tIC91c3Ivc3JjL3N5cy5vbGQvcGNpL2lmX3hsLmMJTW9uIERlYyAzMCAy Mjo1NTowMiAyMDAyDQorKysgaWZfeGwuYwlGcmkgSmFuIDEwIDEzOjAyOjAx IDIwMDMNCkBAIC0xMzYyLDEyICsxMzYyLDE2IEBADQogCQkgICAgcGNpX2dl dF9wb3dlcnN0YXRlKGRldikpOw0KIA0KIAkJcGNpX3NldF9wb3dlcnN0YXRl KGRldiwgUENJX1BPV0VSU1RBVEVfRDApOw0KKwkJREVMQVkoMTAwMDApOw0K IA0KIAkJLyogUmVzdG9yZSBQQ0kgY29uZmlnIGRhdGEuICovDQogCQlwY2lf d3JpdGVfY29uZmlnKGRldiwgWExfUENJX0xPSU8sIGlvYmFzZSwgNCk7DQog CQlwY2lfd3JpdGVfY29uZmlnKGRldiwgWExfUENJX0xPTUVNLCBtZW1iYXNl LCA0KTsNCiAJCXBjaV93cml0ZV9jb25maWcoZGV2LCBYTF9QQ0lfSU5UTElO RSwgaXJxLCA0KTsNCiAJfQ0KKw0KKwlpZiAocGNpX2dldF9wb3dlcnN0YXRl KGRldikgIT0gUENJX1BPV0VSU1RBVEVfRDApDQorCQlwcmludGYoIkRvdWcg QmFydG9uJ3MgM2M1NTZCIGNhcmQgZGlkbid0IGNvbWUgb3V0IG9mIHBvd2Vy c2F2aW5nISIpOw0KIA0KIAkvKg0KIAkgKiBNYXAgY29udHJvbC9zdGF0dXMg cmVnaXN0ZXJzLg0K --0-346410064-1042225419=:14055-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message