Date: Fri, 15 Nov 2002 12:24:31 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Andrew Gallatin <gallatin@cs.duke.edu> Cc: Brooks Davis <brooks@one-eyed-alien.net>, Sam Leffler <sam@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: if_xname ( was Re: cvs commit: src/sys/dev/an if_an.c if_an_isa.c if_an_pccard.c if_an_pci.c src/sys/dev/ar if_ar.c src/sys/dev/awi awi.c if_awi_pccard.c src/sys/dev/bge if_bge.c if_bgereg.h src/sys/dev/cm smc90cx6.c src/sys/dev/cnw if_cnw.c src/sys/dev/cs ...) Message-ID: <20021115122431.E4826@Odin.AC.HMC.Edu> In-Reply-To: <15829.21926.961058.610694@grasshopper.cs.duke.edu>; from gallatin@cs.duke.edu on Fri, Nov 15, 2002 at 03:14:30PM -0500 References: <200211142354.gAENstXE004776@repoman.freebsd.org> <20021115143004.A54902@grasshopper.cs.duke.edu> <20021115114335.A4826@Odin.AC.HMC.Edu> <15829.20547.24539.647339@grasshopper.cs.duke.edu> <20021115120447.C4826@Odin.AC.HMC.Edu> <15829.21926.961058.610694@grasshopper.cs.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--cPi+lWm09sJ+d57q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 15, 2002 at 03:14:30PM -0500, Andrew Gallatin wrote: >=20 > But what about ip_if*'s (ab)use of if_unit in the critical path? > Introducing extra code here to do string parsing is my only concern.=20 > If Luigi is OK with it, then I am too. Well, the string compare of if_name was already in the critical path, it now looks at an average of one more character with if_xname so I seriously doubt that will matter. The wildcard case will be slower because it becomes a fnmatch call, but Luigi was actually willing to just nuke that feature. The recent import of fnmatch() into libkern gave me an easy way to implement it much more powerfully. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --cPi+lWm09sJ+d57q Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE91Vf+XY6L6fI4GtQRAn8wAJwPgHWDbG6zxrXEZqZQpLhlOcIz3QCg3itV uIQFtN4lZu/55aLLdbzoLKo= =W7Id -----END PGP SIGNATURE----- --cPi+lWm09sJ+d57q-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021115122431.E4826>