From owner-dev-commits-src-all@freebsd.org Wed Feb 17 20:59:52 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 96EE753276D; Wed, 17 Feb 2021 20:59:52 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DgqwS1PfDz3NTR; Wed, 17 Feb 2021 20:59:51 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.229.168]) by shaw.ca with ESMTPA id CTvIlZB0v2SWTCTvJl2g25; Wed, 17 Feb 2021 13:59:50 -0700 X-Authority-Analysis: v=2.4 cv=fdJod2cF c=1 sm=1 tr=0 ts=602d83c6 a=7AlCcx2GqMg+lh9P3BclKA==:117 a=7AlCcx2GqMg+lh9P3BclKA==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=qa6Q16uM49sA:10 a=6I5d2MoRAAAA:8 a=vUPWEWiMAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=OeR2YKnim2uLRTrlnSYA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=s3Yi14Of9AgBIP63TAoC:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id EE7B397C; Wed, 17 Feb 2021 12:59:46 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 11HKxkCj012745; Wed, 17 Feb 2021 12:59:46 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202102172059.11HKxkCj012745@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "Hartmann, O." cc: Mark Johnston , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 8ba333e02eaa - main - libdtrace: Stop relying on lex compatibility In-reply-to: <20210217214505.0d4b544e@hermann.fritz.box> References: <202102171602.11HG2FVf099522@gitrepo.freebsd.org> <20210217214505.0d4b544e@hermann.fritz.box> Comments: In-reply-to "Hartmann, O." message dated "Wed, 17 Feb 2021 21:45:05 +0100." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 17 Feb 2021 12:59:46 -0800 X-CMAE-Envelope: MS4xfNGdJaT9ubaLNmCxPu/+N6ClsSMiSo064Dv3lG3OUecDUdOZZDO14/VAQEizIoXaRf+ogFObQniytDd/i3IDUgE0OxmOYLv66i9/W3uPzfQG4SdDP343 sAFbrwNVZ/lvoI6lW+cRTeqglXWyhiNZP9iGVwQR3CX2k1UCN2VdybSsXI10tPp6lWulrgQ1l95Nl/BL+k4TpCncyxSmzAjfYS3rYDr1UezQjxpr61FMDgKf gzIjdA87ivk1n8rTrOWr3ffSk+agfwTZu0J04NBbjzQMD3gU38SUS9Hu6v+dqXvH56TrC2mRWnEY6A78bzgVPUERfvTUiDMgMycvQz+UXatO6hVsmy8SFUZ+ oU3mDYWwG5+langVun9sS1I1bV9q7w== X-Rspamd-Queue-Id: 4DgqwS1PfDz3NTR X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 20:59:52 -0000 In message <20210217214505.0d4b544e@hermann.fritz.box>, "Hartmann, O." writes: > --Sig_/xVHYogKjgyXovADc1VoD_Ap > Content-Type: text/plain; charset=US-ASCII > Content-Transfer-Encoding: quoted-printable > > On Wed, 17 Feb 2021 16:02:15 GMT > Mark Johnston wrote: > > > The branch main has been updated by markj: > >=20 > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D8ba333e02eaa59337a4e1d5534= > d4e894344c8226 > >=20 > > commit 8ba333e02eaa59337a4e1d5534d4e894344c8226 > > Author: Mark Johnston > > AuthorDate: 2021-02-17 15:49:38 +0000 > > Commit: Mark Johnston > > CommitDate: 2021-02-17 15:57:19 +0000 > >=20 > > libdtrace: Stop relying on lex compatibility > > =20 > > It does not appear to be required, and as of commit 6b7e592c215f > > ("lex: Do not let input() return 0 when end-of-file is reached") it > > causes input to return 0 instead of EOF when end-of-input is reached. > > =20 > > PR: 253440 > > MFC after: 3 days > > Sponsored by: The FreeBSD Foundation > > --- > > cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h | 2 +- > > cddl/lib/libdtrace/Makefile | 2 -- > > 2 files changed, 1 insertion(+), 3 deletions(-) > >=20 > > diff --git a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h > > b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h index > > f2c60a2b07d4..b3f69bb6329d 100644 --- > > a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h +++ > > b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h @@ -717,7 +717,= > 7 @@ extern > > dt_pcb_t *yypcb; /* pointer to current parser control block */ e > xtern > > char yyintprefix; /* int token prefix for macros (+/-) */ extern char > > yyintsuffix[4]; /* int token suffix ([uUlL]*) */ extern int yyintdecima > l; > > /* int token is decimal (1) or octal/hex (0) */ -extern char yytext[]; > > /* lex input buffer */ +extern char *yytext; /* lex input bu > ffer */ > > extern int yylineno; /* lex line number */ > > extern int yydebug; /* lex debugging */ > > extern dt_node_t *yypragma; /* lex token list for control lines */ > > diff --git a/cddl/lib/libdtrace/Makefile b/cddl/lib/libdtrace/Makefile > > index efd73751e2c0..45ca1692cf48 100644 > > --- a/cddl/lib/libdtrace/Makefile > > +++ b/cddl/lib/libdtrace/Makefile > > @@ -129,8 +129,6 @@ SRCS+=3D dis_tables.c > > DSRCS+=3D regs_x86.d > > .endif > > =20 > > -LFLAGS+=3D-l > > - > > YFLAGS+=3D-d > > =20 > > LIBADD=3D ctf elf proc pthread rtld_db > > _______________________________________________ > > dev-commits-src-main@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main > > To unsubscribe, send any mail to "dev-commits-src-main-unsubscribe@freebs= > d.org" > > This commit breaks buildworld (also breask starting from scratch/clean /usr= > /obj): > > [...] > -MD -MF.depend.arc_os.pico -MTarc_os.pico -std=3Diso9899:1999 -Wno-format-= > zero-length > -fstack-protector-strong -Wsystem-headers -Wall -Wno-format-y2k -Wno-uninit= > ialized > -Wno-pointer-sign -Wno-unknown-pragmas -Wno-empty-body -Wno-string-plus-int > -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value > -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion > -Wno-unused-local-typedef -Wno-address-of-packed-member -Wno-switch -Wno-sw= > itch-enum > -Wno-knr-promoted-parameter -Qunused-arguments -c > /usr/src/sys/contrib/openzfs/module/os/linux/zfs/arc_os.c -o arc_os.pico --- > all_subdir_cddl/lib/libdtrace --- --- dt_names.o --- --- dt_lex.o --- In fi= > le included > from /usr/src/cddl/contrib/opensolaris/lib/libdtrace/common/dt_lex.l:38: > /usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace= > /common/dt_impl.h:720:14: > error: redeclaration of 'yytext' with a different type: 'char *' vs 'char [= > 8192]' extern > char *yytext; /* lex input buffer */ ^ dt_lex.c:1075:6: note: pr= > evious > definition is here char yytext[YYLMAX]; ^ 1 error generated. *** [dt_lex.o]= > Error code 1 > > make[5]: stopped in /usr/src/cddl/lib/libdtrace > --- all_subdir_cddl/lib/libzpool --- > Restart your build without -DNO_CLEAN. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.