Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 Jan 2012 13:28:40 +0900 (JST)
From:      Hiroki Sato <hrs@FreeBSD.org>
To:        eadler@FreeBSD.org
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r230354 - head/usr.sbin/makefs
Message-ID:  <20120123.132840.618925004528110765.hrs@allbsd.org>
In-Reply-To: <CAF6rxg=VWzUcDuk_oN_wepJPejg8JnGBKm5oLXB7Y8JCW52t3w@mail.gmail.com>
References:  <201201200138.q0K1cSou016739@svn.freebsd.org> <20120120.123256.1432718473132856309.hrs@allbsd.org> <CAF6rxg=VWzUcDuk_oN_wepJPejg8JnGBKm5oLXB7Y8JCW52t3w@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Mon_Jan_23_13_28_40_2012_675)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Eitan Adler <eadler@freebsd.org> wrote
  in <CAF6rxg=VWzUcDuk_oN_wepJPejg8JnGBKm5oLXB7Y8JCW52t3w@mail.gmail.com>:

ea> I was was unaware this code was contributed. I just looked at the
ea> NetBSD version and I don't think it suffers from the same problem -
ea> the loop appears to be used later. If that is because of some other

 Just checking, but the variables dot and semi are not used even in
 the NetBSD version since the initial import (in the NetBSD tree).
 What is "the same problem" you mentioned here?  The problem I pointed
 out is just "removing the useless loop would be good but leaving the
 related comments is bad"...

ea> bug fix which could be upstreamed that would be great. On the other
ea> hand I would like to continue with my goal of making the non-contrib
ea> world compilable with CC=gcc46.
ea>
ea> Should I revert this commit?

 I don't think it is needed.  The makefs utility is a special case
 because it will probably diverge from the upstream to support
 FreeBSD-specific feature in the future (this is one of the reasons
 why it is not in contrib/).  It didn't happen so far, however.

 By the way, does gcc46 no longer allow unused code?  Generally
 speaking, I think it is enough to clean up unused code only when we
 actually change the code.

-- Hiroki

----Security_Multipart(Mon_Jan_23_13_28_40_2012_675)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)

iEYEABECAAYFAk8c4fgACgkQTyzT2CeTzy1+pwCfWJuGJplAJB335qdB4fMrYY1Q
clcAoNVXKwsVsjnHVVk0uxVcLDXtJ6OV
=Qzz4
-----END PGP SIGNATURE-----

----Security_Multipart(Mon_Jan_23_13_28_40_2012_675)----



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120123.132840.618925004528110765.hrs>